Port current codebase to S140 softdevice#2
Conversation
|
Tested with |
|
Great, thank you for the contribution! I will soon take a look at it. For the stack overflow, can you maybe test with this pull request? I had to manually increase the default (hardcoded) stack in TinyGo to get the heartrate example to work, but this PR fixes it for me when using the S132 SoftDevice: tinygo-org/tinygo#741 |
|
Tested heartrate example with tinygo-org/tinygo#723 on top tinygo-org/tinygo#741 on pca10056 and works. |
|
There is a lot of duplicate code in this PR, that should really be factored into common files (so you get adapter_sd.go, adapter_s132v6.go, adapter_s140v7.go, etc). I think it will be needed to support |
|
Anything more that can be done to land this PR? Seems like it will be needed by tinygo-org/tinygo#819 |
|
I wonder if tinygo-org/tinygo#822 is sufficient to address what @aykevl mentions in #2 (comment) |
|
@thegrumpylion to avoid duplication of code, I made a new branch (s140v7) originally based on your code but relying on tinygo-org/tinygo#942 to avoid all the code duplication. The only two files left over are adapter_s140.go and adapter_s140.c and they are both very small. Another change is that I renamed the vendored SoftDevice tree to be consistent with the s132v6 tree. What do you think of it? Can it be merged? Note that basically none of your code is left in that PR, it's either modified or directly downloaded from Nordic. |
bbf15de to
f87fda3
Compare
|
I have now merged the s140 branch, so the functionality of this PR is now supported. |
No description provided.