st7789: update saved rotation in SetRotation#568
Merged
Conversation
aykevl
added a commit
to aykevl/things
that referenced
this pull request
May 9, 2023
The touch sensor isn't updated yet, this requires the fix here: tinygo-org/drivers#568
Member
|
Thanks for the fix @aykevl now merging. |
aykevl
added a commit
to aykevl/board
that referenced
this pull request
May 16, 2023
This needed a small fix in the drivers repository, which is now merged: tinygo-org/drivers#568
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this issue in #550. Without it,
Rotation()returns the wrong rotation value.