Add stub for runtime numcgocall and numgoroutine#2705
Merged
aykevl merged 3 commits intotinygo-org:devfrom Mar 19, 2022
Merged
Conversation
Member
|
Note that |
Contributor
Author
deadprogram
approved these changes
Mar 19, 2022
Member
TinyGo does support goroutines. So returning 1 is technically incorrect. But TinyGo doesn't currently track which goroutines are still alive (they just get garbage collected when finished) so there is no way to know.
For compatibility, I think returning 0 would be fine. Can you update the comments to point out these are stubs and don't return the real value? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a stub for
NumCgoCall,NumGoroutineandVersionfunctions from the runtime package.Since the multi-threading is currently not supported, hard coding
NumGoroutinevalue to 1 (main thread),NumCgoCallto 0and lastly for the. From what I can see this change should not break anything since these functions don't already exist.VersionIt is either the commit hash, date of the build or release tag but I have just put inv0.1.0for now