Revert "fix(e2e): rewrite performFullLogin and extend walkOnboarding for 6-st…"

[graycyrus]

Reverts #303

Summary by CodeRabbit

Release Notes

This pull request contains only internal test infrastructure updates with no end-user facing changes. The modifications streamline automated testing workflows for onboarding processes.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 166182b2-4794-44d8-8f9f-e2caf39defe7

📥 Commits

Reviewing files that changed from the base of the PR and between 11b708a and 6506cd1.

📒 Files selected for processing (2)

• app/test/e2e/helpers/shared-flows.ts
• app/test/e2e/specs/auth-access-control.spec.ts

---

📝 Walkthrough

Walkthrough

Simplifies E2E onboarding test helpers by removing recovery-phrase-specific handling and the mnemonic completion step. Eliminates the "Finish Setup" fallback button logic from the shared helper and consolidates login flow into the test spec with a local performFullLogin implementation.

Changes

Cohort / File(s)	Summary
E2E Onboarding Helper app/test/e2e/helpers/shared-flows.ts	Removed completeMnemonicStep() function and recovery-phrase overlay labels. Reworked walkOnboarding() to advance using only the "Continue" button (no "Finish Setup" fallback), reduced loop bounds from 7 to 6 passes, and adjusted stalled-condition retry logic to check for "Install Skills" presence only.
Auth Access Control Test app/test/e2e/specs/auth-access-control.spec.ts	Added local performFullLogin(token) implementation handling auth deep-link triggering, bootstrap verification, POST request validation, optional user-profile check, onboarding execution via walkOnboarding(), and home-page confirmation. Updated imports and simplified test by removing inline request assertions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• [Feature] E2E: Rewrite performFullLogin() in auth-access-control.spec.ts #200 — Directly modifies performFullLogin in auth-access-control.spec.ts to use the updated walkOnboarding 6-step flow.
• [Feature] E2E: Update completeOnboardingIfVisible() across specs #201 — Updates E2E onboarding helper logic to match the new flow by removing legacy/mnemonic branching.
• [Feature] Fix onboarding bugs and update E2E tests for Login → Onboarding → Home flow #189 — Aligns onboarding helpers and performFullLogin with the new 6-step onboarding flow, removing mnemonic handling.

Possibly related PRs

• refactor(onboarding): remove MnemonicStep and Open Accessibility button, add Recovery Phrase settings panel #279 — Removes MnemonicStep from onboarding and moves recovery-phrase functionality to Settings, corresponding to the mnemonic-handling removal in this PR.
• Feat: update complete onboarding helper #299 — Modifies E2E onboarding helpers and walkOnboarding delegation in shared-flows.ts alongside this PR's changes.
• fix(e2e): overhaul all E2E specs for Linux tauri-driver #180 — Simplifies E2E shared helpers and onboarding/login flow in the same files affected by this PR.

Suggested reviewers

• senamakel

Poem

🐰 A mnemonic phrase once lived in flow,
But now we've let that branching go,
The onboarding hops with "Continue" alone,
No "Finish Setup" weeds have grown!
One button rules them all, so neat—
Simpler tests make hearts skip a beat. 🎉

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-303-fix/200-e2e-rewrite-perform-full-login

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}