test(rpc,core,billing,team): harden registry + RPC helpers with edge-case coverage

[jwalin-shah]

Summary

Test-only hardening for the Rust core RPC layer and two domain ops modules. No production code changes — every added line lives under #[cfg(test)] or a mod tests block.

Covers:

• src/rpc/mod.rs — RpcOutcome<T> constructor, log handling, and JSON serialization shape
• src/core/mod.rs — ControllerSchema / FieldSchema / TypeSchema metadata invariants
• src/core/dispatch.rs — core dispatch routing, unknown-method behavior
• src/core/jsonrpc.rs — helper contracts: params_to_object, parse_json_params, escape_html, type_name, is_session_expired_error
• src/core/all.rs — validate_params edge cases (missing optional, extra fields, type mismatches)
• src/openhuman/billing/ops.rs — pre-HTTP input validation (empty/whitespace plan, payment method id, coupon code; zero/NaN/±Inf top-up amount; gateway normalization)
• src/openhuman/team/ops.rs — build_api_path edge cases and registry coverage

Why it matters

Locks in the current behavior of the JSON-RPC envelope and pre-HTTP input validation so future refactors of the core registry and adapters (core_server::dispatch, core/jsonrpc) can't silently regress input shape, error messages, or dispatch routing.

Validation

• `cargo test --lib` → 4765 passed (no failures, no ignored)
• `cargo fmt --check` → clean
• `cargo check` → clean

Pre-HTTP billing tests are explicitly documented to only exercise argument checks that run before any HTTP call — no network, no backend, no stored session token required.

Risk

Minimal. Tests only. No runtime behavior change.

Summary by CodeRabbit

Release Notes

• Tests
  • Added comprehensive unit tests for input validation, parameter handling, and error reporting across core routing and RPC layers
  • Expanded coverage for JSON-RPC helper functions and schema validation
  • Added validation tests for billing operations and team management functions

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6749b762-f18a-4df1-8083-02082b4cdf6a

📥 Commits

Reviewing files that changed from the base of the PR and between b3b451f and 2dd76c8.

📒 Files selected for processing (7)

• src/core/all.rs
• src/core/dispatch.rs
• src/core/jsonrpc.rs
• src/core/mod.rs
• src/openhuman/billing/ops.rs
• src/openhuman/team/ops.rs
• src/rpc/mod.rs

---

📝 Walkthrough

Walkthrough

This PR adds comprehensive unit tests across core and openhuman modules, covering parameter validation, registry validation, RPC routing, JSON-RPC helpers, schema types, billing operations, team operations, and RPC outcome serialization. All changes are test-only with no modifications to public APIs or exports.

Changes

Cohort / File(s)	Summary
Core Validation & Routing src/core/all.rs, src/core/dispatch.rs	Added tests for parameter/registry validation, RPC method routing (including openhuman.health_snapshot), and core method dispatch (core.ping, core.version). Covers edge cases like missing required fields, unknown parameters, and schema mismatches.
Core JSON-RPC & Schema src/core/jsonrpc.rs, src/core/mod.rs	Added tests for JSON-RPC helpers (params_to_object, type_name, parse_json_params, escape_html, is_session_expired_error) and ControllerSchema serialization/equality. Validates parameter shape handling and session expiration detection.
Openhuman Operations src/openhuman/billing/ops.rs, src/openhuman/team/ops.rs	Added pre-HTTP input validation tests for billing (purchase_plan, update_card, top_up_credits, etc.) and team operations (list_members, create_team, remove_member, etc.), including URL path construction and identifier normalization.
RPC Outcome src/rpc/mod.rs	Added tests for RpcOutcome<T> construction, logging, and JSON serialization behavior, covering both bare JSON and envelope-wrapped outputs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• test(coverage): batches 13–18 — Rust unit tests for 40+ modules (#530) #618: Overlapping unit tests in src/core/all.rs for validate_params and rpc_method_name functionality.
• Improve autocomplete observability and runtime controls in settings + JSON-RPC #308: Related changes to RPC outcome logging and controller schema extensions that directly connect to the tested behaviors.
• feat(update): core sidecar self-update with version detection #372: Updates to controller registry and RPC routing logic that align with the test coverage added here.

Suggested reviewers

• senamakel
• graycyrus

Poem

🐰 A rabbit hops through test suites bright,
Validating params left and right,
With schemas checked and routes confirmed,
Each edge case caught, each error learned!
From billing ops to team affairs,
The code now breathes with testing cares. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding comprehensive edge-case test coverage for RPC, core registry, and helper functions across multiple modules.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}