Sync Repository by VectorJet · Pull Request #941 · tinyhumansai/openhuman

VectorJet · 2026-04-26T10:25:14Z

Summary

What changed and why.
Keep this to 3-6 bullets focused on user-visible or architecture-impacting changes.

Problem

What issue or risk this PR addresses.
Include context needed for reviewers to evaluate correctness quickly.

Solution

How the implementation solves the problem.
Note important design decisions and tradeoffs.

Submission Checklist

Unit tests — Vitest (app/) and/or cargo test (core) for logic you add or change
E2E / integration — Where behavior is user-visible or crosses UI → Tauri → sidecar → JSON-RPC; use existing harnesses (app/test/e2e, mock backend, tests/json_rpc_e2e.rs as appropriate)
N/A — If truly not applicable, say why (e.g. change is documentation-only)
Doc comments — /// / //! (Rust), JSDoc or brief file/module headers (TS) on public APIs and non-obvious modules
Inline comments — Where logic, invariants, or edge cases aren’t clear from names alone (keep them grep-friendly; avoid restating the code)

(Any feature related checklist can go in here)

Impact

Runtime/platform impact (desktop/mobile/web/CLI), if any.
Performance, security, migration, or compatibility implications.

Summary by CodeRabbit

Chores
- Migrated build system from Yarn to pnpm (v10.10.0) across all workflows and scripts.
- Added Debian package runtime dependencies for improved compatibility.
New Features
- Added ARM Linux (aarch64) build documentation with setup instructions.
Bug Fixes
- Improved message identification reliability with UUID-based IDs.
- Removed duplicate route configuration.

- Document aarch64 build process in BUILDING.md - Add gtk::init() in tauri-runtime-cef before tray creation - This fixes 'GTK has not been initialized' panic on ARM Linux

…e externalBin - Migrate package.json scripts from yarn to pnpm - Add linux deb bundle config with empty depends in tauri.conf.json - Remove duplicate externalBin key in tauri.conf.json - Add pnpm workspace and lockfiles Amp-Thread-ID: https://ampcode.com/threads/T-019dbb86-6270-709c-ba2e-0dc4ed254adc Co-authored-by: Amp <amp@ampcode.com>

…i#838)

Co-authored-by: Jwalin Shah <jshah1331@gmail.com>

…ably (tinyhumansai#747)

…i#710) (tinyhumansai#839) - Add JSON-RPC handlers for source, global, and topic-based memory retrieval. - Integrate Ollama embeddings for semantic reranking of chunks and summaries. - Implement 15 unit tests for RPC handlers covering parameter parsing and PII redaction. - Redact PII from logs by removing raw source, entity, and node identifiers. - Fix BFS traversal for drill-down and deduplicate results in topic queries. - Add configuration for embedding endpoints, models, and strictness modes. Co-authored-by: sanil-23 <sanil@vezures.xyz> Co-authored-by: Steven Enamakel <enamakel@tinyhumans.ai>

…LLM-summarised squash bodies (tinyhumansai#849)

- Update all workflows to use pnpm instead of yarn - Change cache: yarn to cache: pnpm - Change yarn install to pnpm install - Change yarn workspace to pnpm --filter - Guard setup_tray with warn log level for headless CI environments

Also fix E2E spec pattern resolution from app/ directory

tauri-driver v2.0.5 proxies to WebKitWebDriver (webkit2gtk), but this app uses CEF (tauri-runtime-cef) which has no WebDriver automation. Sessions hang and timeout. Same as the commented-out e2e_linux job in test.yml. Keep workflow_dispatch for manual runs when CEF automation support lands.

…ws, docs - Replace yarn with pnpm in macos:dev script (app/package.json) - Populate linux.deb.depends with GTK/WebKit/X11 runtime packages (tauri.conf.json + control.in) - Replace "Install pnpm" (npm install -g pnpm) with pnpm/action-setup@v4 in all 5 workflows that had pnpm before setup-node, enabling actions/setup-node cache: pnpm to work correctly - Remove duplicate Install pnpm step from test.yml - Remove references to non-existent pnpm-cache step in typecheck.yml - Update docs/BUILDING.md prerequisites and all command examples to use pnpm consistently - Fix hardcoded CEF_DIR hash and .deb filename with glob patterns - Remove redundant workspaces array from root package.json

actions/setup-node cache: pnpm requires pnpm in PATH when setup-node runs, but pnpm/action-setup installs pnpm after setup-node in the execution order. Fix by using pnpm/action-setup's own cache: true to cache the pnpm store, and remove cache: pnpm from setup-node steps across all 6 workflows.

coderabbitai · 2026-04-26T10:25:30Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3dfbde5b-b24b-4eff-bab2-eb8ed06ba8ec

📥 Commits

Reviewing files that changed from the base of the PR and between 7867496 and 360cded.

⛔ Files ignored due to path filters (2)

app/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (27)

.github/workflows/build-windows.yml
.github/workflows/build.yml
.github/workflows/e2e-agent-review.yml
.github/workflows/release.yml
.github/workflows/test.yml
.github/workflows/typecheck.yml
.husky/pre-push
app/package.json
app/scripts/e2e-build.sh
app/scripts/e2e-run-spec.sh
app/src-tauri/src/lib.rs
app/src-tauri/tauri.conf.json
app/src/AppRoutes.tsx
app/src/components/settings/panels/AIPanel.tsx
app/src/pages/Conversations.tsx
app/test/e2e/helpers/artifacts.ts
app/test/e2e/specs/agent-review.spec.ts
app/test/wdio.conf.ts
docs/BUILDING.md
package.json
packages/deb/control.in
pnpm-workspace.yaml
scripts/review/README.md
scripts/review/cli.sh
src/core/all.rs
src/openhuman/webhooks/bus.rs
tests/webview_apis_bridge.rs

📝 Walkthrough

Walkthrough

This pull request performs a comprehensive migration from Yarn to pnpm as the project's package manager, updating GitHub Actions workflows, package manifests, build scripts, and shell hooks. It also adds pnpm workspace configuration, updates build command references, adds Linux/ARM build documentation, removes a redundant routing entry, and refactors WebSocket test infrastructure.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow Migrations `.github/workflows/build-windows.yml`, `.github/workflows/build.yml`, `.github/workflows/e2e-agent-review.yml`, `.github/workflows/release.yml`, `.github/workflows/test.yml`, `.github/workflows/typecheck.yml`	Switched all workflows from Yarn to pnpm v10.10.0 with caching enabled. Replaced `yarn install --frozen-lockfile` with `pnpm install --no-frozen-lockfile`. Updated workspace commands to use `pnpm --filter`. Set Node.js 24 globally, increased memory limits via NODE_OPTIONS, and removed yarn-specific node_modules caching configuration.
Package Manager Configuration `package.json`, `app/package.json`, `pnpm-workspace.yaml`, `.husky/pre-push`	Declared pnpm 10.10.0 as the project's package manager and added workspace config via `pnpm-workspace.yaml`. Updated all root and app scripts to invoke pnpm instead of yarn. Modified husky pre-push hook to use pnpm for format, lint, compile, and rust checks.
Build & Tauri Configuration `app/src-tauri/tauri.conf.json`, `app/scripts/e2e-build.sh`, `app/scripts/e2e-run-spec.sh`	Changed Tauri build commands from npm/npx to pnpm for both dev and production. Added Linux `.deb` bundle runtime dependencies (GTK, WebKit, X11, GLib). Updated E2E scripts to use `pnpm exec` instead of `npx`.
Test Infrastructure & Configuration `app/test/wdio.conf.ts`, `app/test/e2e/helpers/artifacts.ts`, `app/test/e2e/specs/agent-review.spec.ts`, `tests/webview_apis_bridge.rs`	Removed eslint suppression comments from E2E test files. Updated WDIO config to use absolute spec paths and set rootDir. Refactored WebSocket test server to run in dedicated thread with its own Tokio runtime instead of per-test runtime.
Code Quality & Routing `app/src/AppRoutes.tsx`, `app/src/components/settings/panels/AIPanel.tsx`, `app/src/pages/Conversations.tsx`	Removed redundant protected route for notifications. Fixed useEffect dependency array in AIPanel for periodic polling. Switched message ID generation from timestamp-based to UUID-based (`crypto.randomUUID()`).
Logging & Backend Changes `app/src-tauri/src/lib.rs`, `src/core/all.rs`, `src/openhuman/webhooks/bus.rs`	Downgraded tray icon setup failure from error to warning with headless environment note. Removed unused `redirect_links` namespace from controller registry. Removed unused derived skill variable computation.
Documentation & Scripts `docs/BUILDING.md`, `scripts/review/README.md`, `scripts/review/cli.sh`	Documented pnpm usage instead of yarn. Added comprehensive ARM Linux (aarch64) build instructions including headless prerequisites, target-specific Tauri command, library path setup, and GTK initialization workaround.
Package Metadata `packages/deb/control.in`	Added explicit runtime dependencies declaration for Debian package including GTK, WebKit, X11, and GLib libraries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

chore: migrate from yarn to pnpm #886 — Performs identical yarn-to-pnpm migration across overlapping files (workflows, package.json scripts, tauri configuration, test files), likely a duplicate or related effort.
feat(linux-arm): add ARM Linux build support and GTK init fix #840 — Adds ARM Linux build documentation and supplies the upstream GTK initialization fix that this PR documents in the build guide.
fix(tests): run webview_apis mock bridge on a dedicated runtime #893 — Refactors the same WebSocket test server infrastructure (tests/webview_apis_bridge.rs) to move mock server off per-test Tokio runtime using dedicated thread/mpsc coordination.

Suggested reviewers

senamakel
graycyrus
M3gA-Mind

Poem

🐰 Hop, skip, and pnpm away!

From yarn to pnpm we spring,
With workflows and workspaces ring,
Tests now thread through the air,
Message IDs cryptographically fair,
Dependency migration takes wing! 🌟

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

VectorJet · 2026-04-26T10:25:49Z

A typo. Closing now.

VectorJet and others added 28 commits April 24, 2026 08:26

docs: add ARM Linux build instructions and GTK init fix

7dbd286

- Document aarch64 build process in BUILDING.md - Add gtk::init() in tauri-runtime-cef before tray creation - This fixes 'GTK has not been initialized' panic on ARM Linux

chore(release): increase Node.js memory limit for builds (tinyhumansa…

008d7a0

…i#838)

feat(home): next-steps card + drop stub /agents route (tinyhumansai#788)

4091c31

Co-authored-by: Jwalin Shah <jshah1331@gmail.com>

fix(webhooks,cron): wire trigger pipeline so agents auto-respond reli…

57a1693

…ably (tinyhumansai#747)

feat(scripts/review): yarn review CLI for sync/review/fix/merge with …

184270a

…LLM-summarised squash bodies (tinyhumansai#849)

update husky pre-push and app package.json scripts to use pnpm

12b2ceb

update remaining app scripts to use pnpm

1328f89

add pnpm install step to all workflows (CI image lacks pnpm)

f6f5a80

update pnpm-lock.yaml to match package.json

39a5063

fix: install pnpm before setup-node to fix pnpm cache lookup

5842141

remove --frozen-lockfile to allow pnpm to update lockfile in CI

06023ba

explicitly use --no-frozen-lockfile (CI has it enabled by default)

23786d0

run cargo fmt to fix formatting

135d5b2

fix: use pnpm exec instead of npx for tauri build

f1c3606

fix: remove caching from typecheck (causes node_modules issues)

90f5d4e

fix: replace remaining npx with pnpm exec

9434071

fix: replace npm with pnpm in tauri.conf.json beforeBuildCommand

3b93c28

fix: add NODE_OPTIONS heap limit and opt into Node.js 24 for CI

4758c08

Also fix E2E spec pattern resolution from app/ directory

fix lint: reorder functions before useEffect, use crypto.randomUUID

eb16d13

fix: remove duplicate pnpm cache, remove eslint-disable comments

2d8580e

fix(tests): keep webview apis mock server alive across tokio tests

3c6b1c3

test(webview_apis): keep bridge assertions on one tokio runtime

360cded

VectorJet requested a review from a team April 26, 2026 10:25

VectorJet closed this Apr 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync Repository#941

Sync Repository#941
VectorJet wants to merge 28 commits intotinyhumansai:mainfrom
VectorJet:main

VectorJet commented Apr 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 26, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

VectorJet commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

VectorJet commented Apr 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Submission Checklist

Impact

Related

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

VectorJet commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

VectorJet commented Apr 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 26, 2026 •

edited

Loading