chore(deps): upgrade to Vite 8 and Rolldown#942
Conversation
- vite: ^7.0.4 → ^8.0.0 - @vitejs/plugin-react: ^4.6.0 → ^6.0.1 - vite-plugin-node-polyfills: ^0.25.0 → ^0.26.0 - Vite 8 uses Rolldown (Rust-based bundler) replacing Rollup - Update pnpm-lock.yaml with frozen dependency tree Known: vite-plugin-node-polyfills emits deprecation warning for esbuild option (superseded by oxc). Non-blocking - plugin works. Upstream fix in progress: davidmyersdev/vite-plugin-node-polyfills#154
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 56 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe pull request upgrades the Vite build toolchain to major versions ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
senamakel
left a comment
senamakel
left a comment
There was a problem hiding this comment.
do push the changes to the tauri-cef repo upstream too
|
The changes are already up on the tauri-cef repo — tinyhumansai/tauri-cef#9 is open and targets
No uncommitted/unstaged changes in the submodule — working tree is clean. Once tauri-cef#9 is merged I'll update the submodule pointer here to the new tip of |
tauri-cef#9 merged into feat/cef — includes: - fix(cef-notifications): shim diagnostics + handler lifecycle cleanup - feat(cef): allow overriding CEF cache path via OPENHUMAN_CEF_CACHE_PATH
|
tauri-cef#9 is now merged. I've bumped the submodule pointer in this branch to the new tip of |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/package.json (1)
105-126:⚠️ Potential issue | 🟡 MinorVersion bumps are compatible; add Node engine floor to app/package.json.
All three pins are mutually compatible:
@vitejs/plugin-reactv6 requires Vite 8, and vite-plugin-node-polyfills 0.26.0 is compatible with both. Sinceapp/vite.config.tsusesreact()with no options and contains no deprecated keys (rollupOptions,esbuild,optimizeDeps.esbuildOptions), the plugin-react v6 Babel removal is a no-op here.However,
app/package.jsonlacks anenginesfield, even though Vite 8 requires Node.js 20.19+ or 22.12+. CI is protected (GitHub Actions enforce Node 24.x across all workflows), but local development on older Node versions will silently fail during install/build. Add an explicitenginesfield matching the CI floor (e.g.,"node": ">=20.19"or"node": ">=22.12") to surface the constraint early.The upstream esbuild→oxc deprecation warning from vite-plugin-node-polyfills (PR davidmyersdev/vite-plugin-node-polyfills#154) is expected noise until the plugin updates; this does not block the upgrade.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/package.json` around lines 105 - 126, Add an "engines" field to package.json specifying the minimum Node.js version used in CI so local installs/builds fail fast; for example add "engines": { "node": ">=20.19" } (or ">=22.12" if you prefer the higher floor) at the top level of package.json to surface the Node requirement; ensure the key is a top-level "engines" entry so package managers and editor tooling will enforce the constraint.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@app/package.json`:
- Around line 105-126: Add an "engines" field to package.json specifying the
minimum Node.js version used in CI so local installs/builds fail fast; for
example add "engines": { "node": ">=20.19" } (or ">=22.12" if you prefer the
higher floor) at the top level of package.json to surface the Node requirement;
ensure the key is a top-level "engines" entry so package managers and editor
tooling will enforce the constraint.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a57d1e09-1fe8-4a5a-9d7d-3f8ba062afb5
⛔ Files ignored due to path filters (2)
app/src-tauri/Cargo.lockis excluded by!**/*.lockpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
app/package.jsonapp/src-tauri/vendor/tauri-cef
Matches CI node-version (24.x) so local installs fail fast with clear version mismatch errors.
|
@senamakel can you be clear about what you want? |
2 participants
Summary
Known Issues
Testing
Summary by CodeRabbit