docs(domains): add foundation domain READMEs (#966)#999
docs(domains): add foundation domain READMEs (#966)#999senamakel merged 14 commits intotinyhumansai:mainfrom
Conversation
Adds src/openhuman/agent/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::agent::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/memory/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::memory::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/channels/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::channels::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/skills/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::skills::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/cron/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::cron::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/config/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::config::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/app_state/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::app_state::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/security/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::security::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/accessibility/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::accessibility::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/local_ai/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::local_ai::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/openhuman/encryption/README.md following the strict 5-section template (Responsibility / Public surface / Calls into / Called by / Tests). Content derived from reading mod.rs / ops.rs / schemas.rs and grepping consumers via `use crate::openhuman::encryption::`. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds src/core/event_bus/README.md following the strict 5-section template. Documents the singleton pub/sub + native request/response registry, listing DomainEvent variants and the eight registered domains. Closes tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds README documentation files for the event bus and 11 openhuman domain modules. Changes are documentation-only and introduce module responsibility summaries, public surface listings, integration mappings, and test pointers. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/core/event_bus/README.md`:
- Line 9: The README entry for init_global is incorrect: update the description
for pub fn init_global(capacity: usize) -> &'static EventBus to state that it
initializes once and panics if called more than once (matching the
panic-on-second-init semantics in bus.rs), replacing the current “safe to call
repeatedly” wording so the docs align with the implementation.
In `@src/openhuman/agent/README.md`:
- Line 3: Update the README sentence that claims "prompt section data lives in
`context/`" to reflect that prompt plumbing was moved to the
openhuman::agent::prompts module (retain that context::prompt now acts only as a
shim), so change the wording to mention openhuman::agent::prompts and
context::prompt shim to match the module boundary described in mod.rs.
In `@src/openhuman/app_state/README.md`:
- Line 3: The opening responsibility sentence in the README currently reads
"Aggregator the React shell polls every few seconds..." which is missing a
connector; update that sentence to include the missing word (e.g., change to
"Aggregator that the React shell polls every few seconds..." or "Aggregator the
React shell polls every few seconds to render..." whichever matches tone) so it
reads grammatically correct—locate the sentence starting with "Aggregator the
React shell polls" in the README and replace it with the corrected wording.
In `@src/openhuman/skills/README.md`:
- Line 3: Update the README sentence that says the QuickJS-based runtime is
"removed" to avoid implying deletion: change it to state that this module "does
NOT own runtime execution internals" and note that the skills runtime uses
QuickJS (rquickjs) — i.e., remove the word "removed" and replace with a short
clause clarifying runtime execution (QuickJS/rquickjs) is handled elsewhere in
the skills codebase. Ensure the text still asserts that this component does not
manage runtime/tool execution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7c4c5085-a4d9-4cd2-8a94-57f0f3ff0a83
📒 Files selected for processing (12)
src/core/event_bus/README.mdsrc/openhuman/accessibility/README.mdsrc/openhuman/agent/README.mdsrc/openhuman/app_state/README.mdsrc/openhuman/channels/README.mdsrc/openhuman/config/README.mdsrc/openhuman/cron/README.mdsrc/openhuman/encryption/README.mdsrc/openhuman/local_ai/README.mdsrc/openhuman/memory/README.mdsrc/openhuman/security/README.mdsrc/openhuman/skills/README.md
- event_bus/README.md: init_global panics if called more than once (uses OnceLock::set), not "safe to call repeatedly". - agent/README.md: prompt assets live in agent/prompts/; context/ re-exports them via context::prompt — corrected from "lives in context/" to reflect the actual home. - app_state/README.md: "Aggregator the React shell polls" → "Aggregator that the React shell polls" (grammar). - skills/README.md: rquickjs runtime is still in use, not removed — reword to "does NOT own runtime execution internals" without implying deletion. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
) Earlier "panics if called more than once" wording (from CodeRabbit review) was wrong — bus.rs uses `OnceLock::get_or_init`, which silently returns the already-initialized bus on subsequent calls. The capacity argument from later calls is ignored. Reverts the prior fix to factually-correct wording aligned with the source rustdoc. Refs tinyhumansai#966 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Problem
Foundation domains under `src/openhuman//` and `src/core/event_bus/` had no per-domain README. Engineers landing in a domain dir had to read `mod.rs` + `schemas.rs` + grep consumers themselves to build a mental model — every time. Sub-issue of #773 asked for one README per domain so this work happens once and stays current with the source.
Solution
Each README follows a fixed template:
Content is grounded in actual source: `pub fn`, `pub struct`, `pub trait`, `pub enum`, `pub use` were enumerated from each domain's top-level `*.rs` files; consumer lists from `use crate::openhuman::::` greps.
Submission Checklist
Impact
Related
Summary by CodeRabbit