Skip to content

TINYDOC-3526: Suggested Edits API should not be tied to the existence of the suggested edits toolbar button#4225

Open
kemister85 wants to merge 1 commit into
feature/8.7.0/DOC-3526from
feature/8.7.0/DOC-3526_TINYMCE-13256
Open

TINYDOC-3526: Suggested Edits API should not be tied to the existence of the suggested edits toolbar button#4225
kemister85 wants to merge 1 commit into
feature/8.7.0/DOC-3526from
feature/8.7.0/DOC-3526_TINYMCE-13256

Conversation

@kemister85

@kemister85 kemister85 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Ticket: TINYDOC-3526 (TINYMCE-13256)

Site: Staging

Changes:

  • Added release note entry for TINYMCE-13256 to modules/ROOT/pages/8.7.0-release-notes.adoc (Accompanying Premium plugin changes → Suggested Edits): the SuggestedEditsHasChangesUpdate event now fires whenever the hasChanges API value changes, including on review completion.

Pre-checks:

  • Branch is correctly prefixed (release-note branch)
  • modules/ROOT/nav.adoc has been updated (if applicable).
  • Files have been included where required (if applicable).
  • Files removed have been deleted, not just excluded from the build (if applicable).
  • Files added for New product features include a release note entry.
  • Major or minor version changes have updated the supported-versions.adoc table.
  • Build passes without console errors, warnings, or issues.

…istence of the suggested edits toolbar button
@kemister85 kemister85 added this to the TinyMCE 8.7.0 milestone Jun 18, 2026
@kemister85 kemister85 added the upcoming release Documentation for features currently under development/QA label Jun 18, 2026
@kemister85 kemister85 requested a review from MitchC1999 June 19, 2026 03:14
@kemister85 kemister85 marked this pull request as ready for review June 19, 2026 03:14
@kemister85 kemister85 requested review from a team and soritaheng as code owners June 19, 2026 03:14
@kemister85 kemister85 requested review from ShiridiGandham and tiny-ben-tran and removed request for a team June 19, 2026 03:14
==== Suggested Edits API should not be tied to the existence of the suggested edits toolbar button
// #TINYMCE-13256

Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. An integration that used the API through a custom button, rather than the built-in `suggestededits` toolbar button, did not receive an update when a review finished.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. An integration that used the API through a custom button, rather than the built-in `suggestededits` toolbar button, did not receive an update when a review finished.
Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. As a result, any integration that relied upon the API would not receive an update when a review finished.


Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. An integration that used the API through a custom button, rather than the built-in `suggestededits` toolbar button, did not receive an update when a review finished.

In {productname} {release-version}, the `SuggestedEditsHasChangesUpdate` event fires whenever the value returned by the `hasChanges` API changes, including when a review completes. The `hasChanges` API no longer depends on the presence of the `suggestededits` toolbar button, so a custom integration stays in sync with the document state.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In {productname} {release-version}, the `SuggestedEditsHasChangesUpdate` event fires whenever the value returned by the `hasChanges` API changes, including when a review completes. The `hasChanges` API no longer depends on the presence of the `suggestededits` toolbar button, so a custom integration stays in sync with the document state.
In {productname} {release-version}, the `SuggestedEditsHasChangesUpdate` event fires whenever the value within the `hasChanges` API changes, including when a review completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upcoming release Documentation for features currently under development/QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants