TINYDOC-3526: Suggested Edits API should not be tied to the existence of the suggested edits toolbar button#4225
Open
kemister85 wants to merge 1 commit into
Conversation
…istence of the suggested edits toolbar button
MitchC1999
approved these changes
Jun 19, 2026
| ==== Suggested Edits API should not be tied to the existence of the suggested edits toolbar button | ||
| // #TINYMCE-13256 | ||
|
|
||
| Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. An integration that used the API through a custom button, rather than the built-in `suggestededits` toolbar button, did not receive an update when a review finished. |
Contributor
There was a problem hiding this comment.
Suggested change
| Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. An integration that used the API through a custom button, rather than the built-in `suggestededits` toolbar button, did not receive an update when a review finished. | |
| Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. As a result, any integration that relied upon the API would not receive an update when a review finished. |
|
|
||
| Previously, the `SuggestedEditsHasChangesUpdate` event only fired alongside other editor events, such as typing, selecting, or focusing. Completing a review did not fire the event on its own, so the value returned by the `hasChanges` API could become outdated. An integration that used the API through a custom button, rather than the built-in `suggestededits` toolbar button, did not receive an update when a review finished. | ||
|
|
||
| In {productname} {release-version}, the `SuggestedEditsHasChangesUpdate` event fires whenever the value returned by the `hasChanges` API changes, including when a review completes. The `hasChanges` API no longer depends on the presence of the `suggestededits` toolbar button, so a custom integration stays in sync with the document state. |
Contributor
There was a problem hiding this comment.
Suggested change
| In {productname} {release-version}, the `SuggestedEditsHasChangesUpdate` event fires whenever the value returned by the `hasChanges` API changes, including when a review completes. The `hasChanges` API no longer depends on the presence of the `suggestededits` toolbar button, so a custom integration stays in sync with the document state. | |
| In {productname} {release-version}, the `SuggestedEditsHasChangesUpdate` event fires whenever the value within the `hasChanges` API changes, including when a review completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: TINYDOC-3526 (TINYMCE-13256)
Site: Staging
Changes:
modules/ROOT/pages/8.7.0-release-notes.adoc(Accompanying Premium plugin changes → Suggested Edits): theSuggestedEditsHasChangesUpdateevent now fires whenever thehasChangesAPI value changes, including on review completion.Pre-checks:
Branch is correctly prefixed(release-note branch)modules/ROOT/nav.adochas been updated (if applicable).Files removed have been deleted, not just excluded from the build (if applicable).Files added for New product features include arelease noteentry.Major or minor version changes have updated thesupported-versions.adoctable.