fix: resolve failing test, 50 ruff lint errors, and missing pytest-cov dependency#159
Merged
tirth8205 merged 1 commit intotirth8205:mainfrom Apr 11, 2026
Merged
Conversation
1. Fix test_imports_from_cells: The sample_notebook.ipynb fixture was missing import statements (os, pathlib, math) that the test expected. Added imports to cells 1 and 2 of the fixture. 2. Fix 50 ruff lint errors: Auto-fixed 12 errors (import sorting, unused imports in test files). Configured per-file-ignores and exclusions for the remaining errors in diagram DSL scripts (intentionally compact style), Databricks notebook fixtures (SQL/R/Scala syntax), and test fixture files. 3. Add pytest-cov to dev dependencies: Required for coverage reporting but was not declared in pyproject.toml optional dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tirth8205
added a commit
that referenced
this pull request
Apr 11, 2026
Unreleased fixes since v2.2.2 that users are complaining about: - #208 Claude Code hook schema (fixes #97, #138, #163, #168, #172, #182, #188, #191, #201) — v2.2.2 generates an invalid hooks schema and timeouts in ms instead of seconds; PreCommit is also not a real event. - #205 SQLite transaction nesting (fixes #110, #135, #181) — implicit transactions from the legacy sqlite3 default caused "cannot start a transaction within a transaction" on update. - #166 Go method receivers resolved from field_identifier. - #170 UTF-8 decode errors in detect_changes (fixes #169). - #142 --platform target filters (fixes #133). - #213 / #183 large-repo community detection hangs. - #220 CI lint + tomllib on Python 3.10. - #159 missing pytest-cov dev dep. - #154 JSX component CALLS edges. Plus features: #177 Codex, #165 Luau (#153), #217 REFERENCES edge, #215 recurse_submodules, #185 gitignore default (#175), #171 gitignore docs (#157). Verified locally on Python 3.11: ruff clean, mypy clean, bandit clean, 691 tests pass, coverage 73.72%. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tirth8205
added a commit
that referenced
this pull request
Apr 11, 2026
Unreleased fixes since v2.2.2 that users are complaining about: - #208 Claude Code hook schema (fixes #97, #138, #163, #168, #172, #182, #188, #191, #201) — v2.2.2 generates an invalid hooks schema and timeouts in ms instead of seconds; PreCommit is also not a real event. - #205 SQLite transaction nesting (fixes #110, #135, #181) — implicit transactions from the legacy sqlite3 default caused "cannot start a transaction within a transaction" on update. - #166 Go method receivers resolved from field_identifier. - #170 UTF-8 decode errors in detect_changes (fixes #169). - #142 --platform target filters (fixes #133). - #213 / #183 large-repo community detection hangs. - #220 CI lint + tomllib on Python 3.10. - #159 missing pytest-cov dev dep. - #154 JSX component CALLS edges. Plus features: #177 Codex, #165 Luau (#153), #217 REFERENCES edge, #215 recurse_submodules, #185 gitignore default (#175), #171 gitignore docs (#157). Verified locally on Python 3.11: ruff clean, mypy clean, bandit clean, 691 tests pass, coverage 73.72%. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failing test fix (
test_imports_from_cells): Thesample_notebook.ipynbfixture was missing import statements (os,pathlib,math) that the test expected to find asIMPORTS_FROMedges. Addedimport osandfrom pathlib import Pathto cell 1 (alongside existing magic lines) andimport mathto cell 2, preserving all existing cell index assertions.Ruff lint errors (50 total): Auto-fixed 12 errors (import sorting in
test_tools.py, unusedshutilimport, trailing newline in fixture). Configured proper exclusions and per-file-ignores for the remaining 38 errors:diagrams/directory — DSL scripts use intentionally compact, non-standard style (semicolons, single-letter function names, long lines)sample_databricks_notebook.ipynb— SQL/R/Scala cells produce syntax errors when parsed as Pythonsample_databricks_export.py(unused variable, trailing newline in fixture)sample_notebook.ipynb(intentionally unused imports, cross-cell import blocks)test_multilang.py(long assertion lines with explanatory comments)Missing dependency: Added
pytest-covto the[project.optional-dependencies] devgroup, required for--covcoverage reporting.Test plan
pytest— 620 passed, 2 xpassed)ruff check .reports zero errorstest_imports_from_cellsspecifically passes with correct import targetstest_cell_index_trackingstill passes (cell indices unchanged)test_skips_magic_commandsstill passes (magic line filtering unaffected)🤖 Generated with Claude Code