Support for X9.62 formatted public keys#118
Merged
tomato42 merged 4 commits intotlsfuzzer:masterfrom Oct 1, 2019
Merged
Conversation
tomato42
force-pushed
the
point-compression
branch
3 times, most recently
from
1111ff9 to
d1670c7
Compare
Member
Author
|
@trancee, @mdxs, @mg6maciej, @techguy613, @SimoneBronzini, @florensie, @nomeata: (I've tagged you as you have expressed interest in this feature in one of the above mentioned PRs or issues) |
This was referenced Sep 29, 2019
t8m
approved these changes
Oct 1, 2019
t8m
left a comment
t8m
left a comment
There was a problem hiding this comment.
LGTM (with or without the exception name change)
Adds support for encoding and decoding verifying keys in format specified in SEC 1 or in X9.62. Specifically the uncompressed point encoding and the compressed point encoding
make the decoding of malformed point raise the same exception irrespective of the formatting of the key/public point
reuse the new to_string and from_string to support saving and reading the public key in PEM and DER files with both compressed and uncompressed point encoding
the X9.62 standard defines also a hybrid public key representation, add support for it
tomato42
force-pushed
the
point-compression
branch
from
53783c3 to
cb15e5f
Compare
This was referenced Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is re-working of the PR #54 (which in turn is a reworking of #34).
This implements support for the compressed, uncompressed and hybrid format specified in X9.62 and the SEC1 standards
http://www.secg.org/sec1-v2.pdf
fixes #1, #53
closes #54, #34
I'm not adding documentation as I plan to do that either in #117 or after #117 is merged