Merged
Conversation
tomato42
force-pushed
the
backport-sig-decode
branch
4 times, most recently
from
1439b29 to
9c7ebc3
Compare
tomato42
force-pushed
the
backport-sig-decode
branch
5 times, most recently
from
e204c2d to
8adaa3b
Compare
tomato42
force-pushed
the
backport-sig-decode
branch
from
8adaa3b to
2dc0d7a
Compare
Merged
Member
Author
|
@Jakuje please review |
Jakuje
approved these changes
Oct 7, 2019
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
There are some nits along the lines, but considering it is backport of something already in master, we should not bother that much with the messy history of the commits.
Only thing that might make sense could be mentioning the master commits IDs in the cherry-picked so it is obvious that it is backport.
the users of VerifyingKey.verify() and VerifyingKey.verify_digest() should not need to use multiple exceptions to correctly catch invalid signatures backport of 487f6d3
Verify that strings of unexpected lengths are rejected with the same BadSignatureError exception backport of 8533e51
the same issues as with decoding integers happen with the NIST521p curve as it's large enough that the length encoding of some fields needs to use multi-byte encoding backport of a655d6f
…nteger backport of 2c3db7c
as assert statements will be removed in optimised build, do use a custom exception that inherits from AssertionError so that the failures are caught this is reworking of d47a238 to implement the same checks but without implementing support for SEC1/X9.62 formatted keys
not a backport, necessary to make the tests runnable on 0.13 branch
proposed for master in tlsfuzzer#132
tomato42
force-pushed
the
backport-sig-decode
branch
from
2dc0d7a to
1eb2c04
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the recent fixes to signature decoding.
See #114
also harden the public and private key decoding (partial backport of #118)