feature(db): Remove database APIs.#16
Open
miuraken wants to merge 1 commit into
Open
Conversation
…for GAE Python3 as beta
kencanak
suggested changes
Dec 11, 2019
kencanak
left a comment
There was a problem hiding this comment.
@miuraken , I understand that google-cloud-ndb lib is now available, however, I think we should keep the db interface for accessing ndb. For example, in our current firestore/datastore interface, we have methods to convert it to plain json, save document, search/get all documents.
@skezo what do you think?
Author
|
Does this DB interface contribute to improve security? Can we separate such useful goodies from the scaffold and put them into another library? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google-cloud-ndb is now available for GAE Python3 as beta.
https://googleapis.dev/python/python-ndb/latest/index.html