Skip to content

feature(db): Remove database APIs.#16

Open
miuraken wants to merge 1 commit into
toasterco:masterfrom
miuraken:remove-orm
Open

feature(db): Remove database APIs.#16
miuraken wants to merge 1 commit into
toasterco:masterfrom
miuraken:remove-orm

Conversation

@miuraken
Copy link
Copy Markdown

@miuraken miuraken commented Dec 5, 2019

google-cloud-ndb is now available for GAE Python3 as beta.
https://googleapis.dev/python/python-ndb/latest/index.html

Copy link
Copy Markdown

@kencanak kencanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miuraken , I understand that google-cloud-ndb lib is now available, however, I think we should keep the db interface for accessing ndb. For example, in our current firestore/datastore interface, we have methods to convert it to plain json, save document, search/get all documents.

@skezo what do you think?

@kencanak kencanak requested a review from skezo December 11, 2019 02:36
@miuraken
Copy link
Copy Markdown
Author

Does this DB interface contribute to improve security?
Ideally, we want to make Secure Scaffold as minimal as possible.

Can we separate such useful goodies from the scaffold and put them into another library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants