Skip to content

fix: improve virtual module handling to support storybook v8 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasdiez merged 1 commit into from
Aug 20, 2024
Merged

fix: improve virtual module handling to support storybook v8 #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: improve virtual module handling to support storybook v8 
Fixes #103.
  • Loading branch information
@tobiasdiez
tobiasdiez committed Aug 20, 2024
commit 4ad79d799eba85cf355b8bdf606f1ef70a9bcc0d
2 changes: 1 addition & 1 deletion src/core/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { consola } from 'consola'
export const logger = consola.withTag('[storybook:vue]')
// logger.level = LogLevel.Debug
// logger.level = 4 // Debug
4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ export const unpluginFactory: UnpluginFactory<Options | undefined> = (
...options,
})) as { id: string; external: boolean }

// If it cannot be resolved or is external, just return it so that Rollup can display an error
if (!resolution || resolution.external) return resolution
// If it cannot be resolved or is external, return undefined so that the next plugin can handle it
if (!resolution || resolution.external) return undefined

// We append a custom "type" so that the vue plugin is not handling the import
resolution.id = resolution.id + STORIES_INTERNAL_SUFFIX
Expand Down