declare version of windows-sys by range set to fix compile under win7#1922
Closed
Fenex wants to merge 1 commit intotokio-rs:masterfrom
Closed
declare version of windows-sys by range set to fix compile under win7#1922Fenex wants to merge 1 commit intotokio-rs:masterfrom
windows-sys by range set to fix compile under win7#1922Fenex wants to merge 1 commit intotokio-rs:masterfrom
Conversation
Using a range instead of the default Caret requirements helps avoid duplicate versions in downstream graphs and improves resolver flexibility. Additionally, `windows-sys@0.61+` has a bug that causes compilation errors under `*-win7-windows-*` targets, so this change will allow users to chose older version of `windows-sys` to avoid this bug.
Collaborator
|
I don't want to deal with errors coming from different window-sys versions. Furthermore Windows 7 is not supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaration with range is a recommended way to add
windows-syscrate as dependency:Additionally,
windows-sys@0.61+has a bug that causes compilation errors under*-win7-windows-*targets, so this change will allow your users to choose & lock in theirsCargo.lockolder version ofwindows-systo continue support Windows 7.