Skip to content

[display] add udev rules for adding device targets#431

Merged
matteodelabre merged 6 commits into
testingfrom
display_add_input_rules
Sep 25, 2021
Merged

[display] add udev rules for adding device targets#431
matteodelabre merged 6 commits into
testingfrom
display_add_input_rules

Conversation

@raisjn
Copy link
Copy Markdown
Contributor

@raisjn raisjn commented Sep 14, 2021

this can be used by other services as a dependency to make sure they have their necessary input devices available before starting. this is just one way of approaching the problem (that input devices aren't available when remux is starting). alternatively, can make remux/genie die if the input device is unrecognized

STATUS: untested.

this can be used by other services as a dependency to make sure they
have their necessary input devices available before starting
Copy link
Copy Markdown
Member

@matteodelabre matteodelabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think it would also make sense to add the changes that make the launcher services depend on the input targets in this PR—I can add them to this diff myself if you want.

Comment thread package/display/package Outdated
Comment thread package/display/package Outdated
@raisjn
Copy link
Copy Markdown
Contributor Author

raisjn commented Sep 14, 2021

yes, please add them!

* put input rules into display package no matter what
* put Requires/After into remux.service
@raisjn
Copy link
Copy Markdown
Contributor Author

raisjn commented Sep 15, 2021

PS: this is addressing rmkit-dev/rmkit#141 (adding crosslink so that post gets updated too)

@matteodelabre
Copy link
Copy Markdown
Member

Moved the udev rule to the toltec-bootstrap package as discussed on Discord.

Copy link
Copy Markdown
Member

@matteodelabre matteodelabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on rM2.

@matteodelabre matteodelabre merged commit 335c2fb into testing Sep 25, 2021
@matteodelabre matteodelabre deleted the display_add_input_rules branch September 25, 2021 10:56
matteodelabre added a commit that referenced this pull request Sep 25, 2021
Fixes:

* TLS issues with the bootstrap script (#422, #423)
* Bootstrap script could overwrite existing installs (#409, #423)

Updated packages:

* fbink, fbdepth, fbink-doom - 1.24.0-1 (#425)
* innernet - 1.4.1-2 (#420)
* koreader - 2021.09-1 (#436)
* remux - 0.1.9-5 (#431) (fixes 2.9 issues)
* toltec-bootstrap - 0.2.0-1
@raisjn
Copy link
Copy Markdown
Contributor Author

raisjn commented Oct 2, 2021

i think remux needs to depend on toltec-bootstrap in order to get the udev rules installed and configured

matteodelabre added a commit that referenced this pull request Oct 4, 2021
Fixes:

* TLS issues with the bootstrap script (#422, #423)
* Bootstrap script could overwrite existing installs (#409, #423)

Updated packages:

* fbink, fbdepth, fbink-doom - 1.24.0-1 (#425)
* innernet - 1.4.1-2 (#420)
* koreader - 2021.09-1 (#436)
* remux - 0.1.9-5 (#431) (fixes 2.9 issues)
* toltec-bootstrap - 0.2.0-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants