This repository was archived by the owner on Nov 19, 2020. It is now read-only.
Switch to setuptools and add cythonize to build#25
Merged
tompreston merged 1 commit intotompreston:masterfrom Apr 8, 2019
Merged
Switch to setuptools and add cythonize to build#25tompreston merged 1 commit intotompreston:masterfrom
tompreston merged 1 commit intotompreston:masterfrom
Conversation
Distutils is not fully supported by pip anymore and on newer versions of pip packages installed that are using distuils can't be uninstalled. This can be avoided by switching to setuptools to handle the packaging, which this commit does. Also, to enable working on newer versions of python this commit integrates cythonize to the build workflow. This way regardless of versions the c source file will be generated at build time by cython and then compiled instead of manually generating them before the build. The only tradeoff with this is that Cython becomes a build dependency and must be installed prior to trying to build python-lirc.
Owner
|
Yeah looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distutils is not fully supported by pip anymore and on newer versions of
pip packages installed that are using distuils can't be uninstalled.
This can be avoided by switching to setuptools to handle the packaging,
which this commit does.
Also, to enable working on newer versions of python this commit
integrates cythonize to the build workflow. This way regardless of
versions the c source file will be generated at build time by cython
and then compiled instead of manually generating them before the build.
The only tradeoff with this is that Cython becomes a build dependency
and must be installed prior to trying to build python-lirc.