Skip to content

Erlang compatibility for List Pattern Matching#1615

Merged
tonsky merged 2 commits intotonsky:masterfrom
m-2k:pr-restrict-use-of-underscore-pipe-for-list-pattern-matching-in-erlang
Nov 4, 2024
Merged

Erlang compatibility for List Pattern Matching#1615
tonsky merged 2 commits intotonsky:masterfrom
m-2k:pr-restrict-use-of-underscore-pipe-for-list-pattern-matching-in-erlang

Conversation

@m-2k
Copy link
Copy Markdown
Contributor

@m-2k m-2k commented Oct 16, 2024

Exclude ligatures for [_|_] [_,_|_] [ _|_ ] [ _, _|_ ] from underscores lookup

Screenshot 2024-10-16 at 18 22 50

@m-2k
Copy link
Copy Markdown
Contributor Author

m-2k commented Oct 21, 2024

how long will it take to merge?

@tonsky
Copy link
Copy Markdown
Owner

tonsky commented Oct 21, 2024

I don’t think I like inclusion of space in the ignore pattern. You’ll write it either as [_|_] or [ _ | _ ], no? With just [bracket comma] underscore I can add it

@m-2k
Copy link
Copy Markdown
Contributor Author

m-2k commented Oct 30, 2024

@tonsky

Screenshot 2024-10-30 at 18 48 48

@tonsky tonsky merged commit 259ea72 into tonsky:master Nov 4, 2024
@tonsky
Copy link
Copy Markdown
Owner

tonsky commented Nov 4, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants