Add Ampersand Ligature Variant for ss03#1647
Merged
Conversation
The feature `ss03` changes the ampersand to the traditional style. When this feature is enabled the restyling of the ligature form `ampersand_ampersand.liga` is not used because it does not exist. This commit adds the part glyph `_part.ampersand.ss03`, adds the ligature glyph `ampersand_ampersand.liga.ss03`, and modifies the `ss03` feature to use the newly added ligature when the feature is enabled. The part glyph was only created to be a component for the newly added ligature, like `_part.ampersand` is for `ampersand_ampersand.liga`.
tonsky
added a commit
that referenced
this pull request
May 4, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature
ss03changes the ampersand to the traditional style. When this feature is enabled the restyling of the ligature formampersand_ampersand.ligais not used because it does not exist.This commit adds the part glyph
_part.ampersand.ss03, adds the ligature glyphampersand_ampersand.liga.ss03, and modifies thess03feature to use the newly added ligature when the feature is enabled.The part glyph was only created to be a component for the newly added ligature, like
_part.ampersandis forampersand_ampersand.liga.Here is how the ligature added by this commit looks with the various weights: