Fix automated release process: Updates GHA types and build dependencies#1675
Fix automated release process: Updates GHA types and build dependencies#1675tonsky merged 5 commits intotonsky:masterfrom
Conversation
…n 3.12, sfnt2woff-zopfli)
hunterhogan
left a comment
hunterhogan
left a comment
There was a problem hiding this comment.
Tested the automated release creation files on my fork. A seemingly valid zip was created.
In the GitHub action, I emulated "bootstrap_macos.sh" instead of trying to build a docker container.
In a few places, some code effectively suppressed error reporting. I removed those suppressors so I could see what was happening, but I didn't restore them.
The code was AI assisted (Gemini 3 Pro preview via Copilot). Nevertheless, I have read every line of the code, and I tested it on my account first.
Thank you for making a great font.
tonsky
left a comment
tonsky
left a comment
There was a problem hiding this comment.
Thanks! Mostly looks fine, but I would like to understand what does contents: write do. I don't think I ever needed it in any of my repos
| jobs: | ||
| build: | ||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
My understanding is that it is used to create the artifacts. I only have four workflows and they are all here. https://github.com/hunterhogan/hunterMakesPy/tree/main/.github/workflows The two that create files have write permissions, but the other two only have read.
|
It's been a minute, I’m not sure how this build used to work, and Github Actions backwards compatibility keeps us all busy. Thanks for bringing it up to date! |
2 participants
No description provided.