docs: document the CI OK aggregate required check (toon-meta#279 proof) - #164
Merged
Merged
Conversation
Records how buzz's single required status check works: it recomputes each job's trigger condition from the Detect Changed Paths outputs, so a skipped job only passes when its paths genuinely were not touched, and a docs-only PR still gets a definitive verdict rather than an empty check set. This PR is itself the proof case for that behaviour — it touches no paths-filtered path, so every filtered job skips and CI OK must still report a real pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The previous two attempts had 'Detect Changed Paths' (timeout-minutes: 2) sit ~19 minutes without starting a step before being cancelled — the jobs never got a runner. Retriggering on a fresh SHA to get a clean verdict. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
CI OKaggregate required check added in #154, and is itself the acceptance proof for it.This PR touches exactly one file —
CONTRIBUTING.md— which matches none of theDetect Changed Pathsfilters (rust,desktop,desktop-rust,web,mobile). So every paths-filtered job inci.ymlskips.That is precisely the case toon-meta#279 exists to close. Before the aggregate, such a PR produced an effectively empty check set: nothing verified it, and "no failing checks" was trivially satisfied. Now:
Detect Changed PathsandDead Token Reference Guardrun unconditionally and must succeed.skipped, andCI OKre-evaluates each job's ownif:expression against the detect outputs to confirm the skip was legitimate.CI OKreports a definitive pass — not an absent check, not a neutral one.Had any job been skipped while its filter said it should have run,
CI OKwould fail withJob '<id>' was expected to run ... but was skipped.Part of toon-protocol/toon-meta#270
Part of toon-protocol/toon-meta#279
🤖 Generated with Claude Code