Skip to content

[AgentOps][Minor] Fix the ascii art in tmux tools#484

Merged
XinweiHe merged 1 commit intopivot/agentopsfrom
xinwei_cosmetic_ascii_art_minor_fix_v1
Mar 4, 2026
Merged

[AgentOps][Minor] Fix the ascii art in tmux tools#484
XinweiHe merged 1 commit intopivot/agentopsfrom
xinwei_cosmetic_ascii_art_minor_fix_v1

Conversation

@XinweiHe
Copy link
Collaborator

@XinweiHe XinweiHe commented Mar 4, 2026

Summary

as titled.

Type of Change

  • feat - A new feature
  • fix - A bug fix
  • docs - Documentation only changes
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor - A code change that neither fixes a bug nor adds a feature
  • perf - A code change that improves performance
  • test - Adding missing tests or correcting existing tests
  • build - Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci - Changes to our Cl configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore - Other changes that don't modify sc or test files
  • revert - Reverts a previous commit
  • security - A security fix or improvement
  • github - Changes to our GitHub configuration files and scripts
  • other (please describe):

Details

Screenshots / Recordings (if applicable)

Checklist

  • I have read the CONTRIBUTING.md
  • I have added/updated tests where applicable
  • I have added screenshots or recordings for UI changes (if applicable)
  • I have updated documentation where necessary

@XinweiHe XinweiHe requested a review from a team as a code owner March 4, 2026 05:05
@greptile-apps
Copy link

greptile-apps bot commented Mar 4, 2026

Greptile Summary

This PR makes a minimal, targeted fix to the ASCII art logo displayed in the tmux welcome screen by adding two spaces to the first line, correcting the horizontal alignment of the opening and closing _ characters in the WelcomeScreen.render_text() method in tmux_tools/schema.py.

  • Adds two spaces to the first row of the ASCII logo (line 64) to align the opening _ with the closing _.
  • No logic, control flow, or functional behaviour is changed — this is purely a visual/cosmetic correction to the terminal welcome screen.

Confidence Score: 5/5

  • This PR is entirely safe to merge — it only changes whitespace inside a raw string literal used for ASCII art display.
  • The change is a single two-space addition inside a raw string with no effect on any logic, imports, or runtime behaviour. There are no new dependencies, no altered control flow, and no risk of regressions. The modification is purely visual.
  • No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Driver.run] --> B[build_welcome]
    B --> C[WelcomeScreen]
    C --> D[render_text]
    D --> E[ASCII logo\nfixed alignment]
    D --> F[Instructions text]
    D --> G[web_urls list]
    D --> H[additional_instructions]
    E & F & G & H --> I[Concatenated output string]
    I --> J[tmux Window command via echo]
Loading

Last reviewed commit: c2886d0

@XinweiHe XinweiHe merged commit a2c1ea1 into pivot/agentops Mar 4, 2026
6 checks passed
@XinweiHe XinweiHe deleted the xinwei_cosmetic_ascii_art_minor_fix_v1 branch March 4, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant