fix(ci): replace grep -P with portable sed for cross-platform compatibility#244
Merged
Conversation
…bility - Replaces grep -P (Perl regex, not available on macOS/BSD) with sed -E - Uses POSIX extended regex for better portability - Handles both quoted and unquoted node versions - Skips matrix variables (returns empty, as intended) Fixes CodeRabbit finding from PR #242 about macOS portability. Co-authored-by: CodeRabbit <support@coderabbit.ai>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b08b776fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
iap
added a commit
that referenced
this pull request
Jun 2, 2026
…bility (#244) - Replaces grep -P (Perl regex, not available on macOS/BSD) with sed -E - Uses POSIX extended regex for better portability - Handles both quoted and unquoted node versions - Skips matrix variables (returns empty, as intended) Fixes CodeRabbit finding from PR #242 about macOS portability. Co-authored-by: CodeRabbit <support@coderabbit.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeRabbit finding from PR #242 about macOS/BSD portability.
Problem
grep -P(Perl regex) is not available on macOS/BSD systems by default, causing the workflow validation script to fail on those platforms.Solution
grep -Pwithsed -E(POSIX extended regex)24.16.0)Changes
Testing
Related