This repository was archived by the owner on Feb 11, 2026. It is now read-only.
Adjust UUID formatting for static data tables#6
Merged
Conversation
In the case where a table has neither an updated_at column nor a created_at column, the call to json.dumps() was missing an argument that is included in the other cases.
jesset-truss
approved these changes
Mar 30, 2023
Contributor
jesset-truss
left a comment
jesset-truss
left a comment
There was a problem hiding this comment.
Looks good and tested successfully!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Slack Thread
In the case where a table has neither an updated_at column nor a created_at column, the call to json.dumps() was missing a default arg, so the UUIDs are not returned as
obj.hexwhich was interfering with joins to these tables.