This repository was archived by the owner on Apr 23, 2026. It is now read-only.
B-23444 Enable saving of PDF rotation#14
Merged
Conversation
traskowskycaci
changed the title
traskowskycaci
requested review from
a team,
TevinAdams,
cameroncaci,
danieljordan-caci and
deandreJones
cameroncaci
reviewed
May 8, 2025
cameroncaci
left a comment
cameroncaci
left a comment
There was a problem hiding this comment.
@traskowskycaci Is that webpack chunk with the debug mode turned on?
Author
Great catch @cameroncaci, regenerated those files with a fresh yarn build |
danieljordan-caci
approved these changes
May 9, 2025
|
Gonna merge and release this one to help out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
Some previous work was done to enable rotating and saving files, but the .pdf file type was missed as part of that work. This adds functionality in the pdf-viewer driver to save and rerender PDFs when rotated.