Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

B-23280: Update document viewing zoom scale#15

Merged
cameroncaci merged 5 commits into
mainfrom
B-23280-doc-viewing-drivers
May 23, 2025
Merged

B-23280: Update document viewing zoom scale#15
cameroncaci merged 5 commits into
mainfrom
B-23280-doc-viewing-drivers

Conversation

@traskowskycaci
Copy link
Copy Markdown

@traskowskycaci traskowskycaci commented May 19, 2025

Agility ticket

  • Lots of trial and error to add a nicer looking default zoom scale based on the dimensions of an image
  • Zoom scale of 10% up to 200%, with default being 100%
  • Sending the current zoom percentage to the UI to be displayed next to the Zoom in and Zoom out buttons in the document viewer
  • Cleaning up references to Photo360Viewer. I found a bug in this code, and determined we no longer need to even use it, as we can simplify and use the PhotoViewer. The use cases of a photo with the dimensions for triggering the use of Photo360Viewer would be rare, and not an image size that should be uploaded as part of our business process. If one is uploaded, we can still render it via PhotoViewer

@traskowskycaci traskowskycaci self-assigned this May 19, 2025
@traskowskycaci traskowskycaci changed the title B-23280 Update drivers with document viewing zoom scale B-23280 Update document viewing zoom scale May 19, 2025
@traskowskycaci traskowskycaci changed the title B-23280 Update document viewing zoom scale B-23280: Update document viewing zoom scale May 19, 2025
@traskowskycaci traskowskycaci marked this pull request as ready for review May 19, 2025 22:43
Copy link
Copy Markdown

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, BUUUUUTTTT. Going backwards it doesn't do the 10,25,50,75,100 order.

Like zooming in you go:
110, 125, 150, 175, 200

But out is:
100 -> 75 -> 50 -> 25 -> 10


Also I think we need to take out my portion of the AC here:

(Eg if you click zoom in 3 times, you will be at 150%, but if you zoom out, it should go to 140%

I believe I was incorrect with this example. What you currently have is definitely better

Copy link
Copy Markdown

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets AC, good for POA

Copy link
Copy Markdown
Author

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not authorized to merge in so @cameroncaci is going to assist on getting this in, then I will pull the new version into the mymove repo

@cameroncaci cameroncaci merged commit f336268 into main May 23, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants