Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

B-26359 Update photo viewer to fill space available by default#18

Merged
r-mettler merged 2 commits into
mainfrom
B-26359
Apr 1, 2026
Merged

B-26359 Update photo viewer to fill space available by default#18
r-mettler merged 2 commits into
mainfrom
B-26359

Conversation

@ajlusk
Copy link
Copy Markdown

@ajlusk ajlusk commented Mar 29, 2026

B-26359

Not directly part of the AC but the photo viewer (just the photo viewer, not the PDF viewer) wasn't taking up the full width available to it, resulting it poor UX with a scroll bar in the middle of the screen. The primary changes for B-26359 created more space for this to fill and this change should allow it to take up all the space available to it by default ideally without affecting the ability to use the existing sizing behavior.

Testing Instructions

If you want to see a before and after rather than just the after, do step 3 first.

  1. Update your local to use github:transcom/react-file-viewer#v1.4.6 for it the dependency @transcom/react-file-viewer
  2. Clear and reinstall your npm modules with rm -rf node_modules then yarn install, we don't want a frozen lockfile
  3. Anywhere in the app upload a handful of image files that you'll be able to review in the document viewer like orders and navigate to viewing them.
  4. Verify the center component where the image is displayed fills the space available to it, the vertical scrollbar is flush against the right sidebar, and the horizontal scrollbar is not hidden by the the controls bar at the bottom.

@ajlusk ajlusk requested review from a team, antgmann and r-mettler March 29, 2026 19:40
@ajlusk ajlusk self-assigned this Mar 29, 2026
@r-mettler r-mettler merged commit 062ea7b into main Apr 1, 2026
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants