This repository was archived by the owner on Apr 23, 2026. It is now read-only.
B-26364 adjust for comments#20
Merged
Merged
Conversation
r-mettler
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B-26364
Important
This MR addresses comments received, will necessitate version 1.5.1
These changes provide some rather significant adjustments to how we display images, as well as how pdfs appear visually. Because of this, a new minor version (1.5.0) may be appropriate. Amongst the improvements:
Testing Instructions
These changes are made based upon Alex's changes for 26359, hence the dependency. In order to best test these changes, please check out the B-26364 branch in our repository before testing.
Also, if you want to see a before and after rather than just the after, do step 3 first.
"@transcom/react-file-viewer": "git+https://github.com/transcom/react-file-viewer#B-26364-viewer-fit",in package.jsonrm -rf node_modules && yarn install && ./scripts/copy-react-file-viewer && make client_run)