Skip to content

Publish coverage with GitHub Pages#429

Merged
kvz merged 1 commit into
mainfrom
pages-coverage
Jun 8, 2026
Merged

Publish coverage with GitHub Pages#429
kvz merged 1 commit into
mainfrom
pages-coverage

Conversation

@kvz

@kvz kvz commented Jun 8, 2026

Copy link
Copy Markdown
Member

Why

The previous public coverage publishing flow pushed generated files from transloadit/node-sdk into transloadit/node-sdk-coverage with a deploy key. That cross-repo write credential is unnecessary now that GitHub Pages supports Actions-based deployments from the same repository. This supersedes the signing workaround in #427 by removing the generated git push entirely.

What changed

  • Replaces the node-sdk-coverage checkout/push steps with same-repo GitHub Pages deployment.
  • Uploads the generated static-build directory as a normal artifact from the E2E job.
  • Adds a separate Publish coverage Pages job with only contents: read, pages: write, and id-token: write.
  • Removes all COVERAGE_REPO_* workflow secret references.

Operational notes

Validation

  • git diff --check
  • YAML parse check via Ruby
  • yarn lint:changesets
  • yarn lint:publish

After merge

  • Run/verify the workflow on main.
  • Remove the now-obsolete coverage publish secrets.
  • Remove the old transloadit/node-sdk-coverage repository.

@kvz kvz temporarily deployed to github-pages June 8, 2026 05:51 — with GitHub Actions Inactive
@kvz kvz merged commit 3f53f4c into main Jun 8, 2026
35 of 36 checks passed
@kvz kvz deleted the pages-coverage branch June 8, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant