Improve logging of connection validator#280
Merged
Conversation
Owner
Author
|
@jonathanmarsaud Would you be able to test this? This should print extra logging about the path being used. |
|
@treydock Thanks, I tested it and now I have: |
7936e64 to
e9361d4
Compare
Owner
Author
|
@jonathanmarsaud Try testing again. I think I fixed the relative path handling for validator. |
Fix path handling for relative paths in validator Fixes #279
e9361d4 to
050a3c6
Compare
Owner
Author
|
I added an acceptance test that validate this now works Once the service was started those cleared up and things worked fine. |
4de4ddc to
0264ce2
Compare
0264ce2 to
179e4d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279