Pass init output to all error handlers

[nicktrn]

Previously, we didn't pass init output to task-level handleError functions - according to the types we should have. The global default handleError function in trigger.config.ts had no init output param at all. This fixes both those issues.

Summary by CodeRabbit

• New Features

  • Enhanced error handling with the addition of a new property for more context during error management.
  • Improved retry logic, allowing for better decision-making based on error types and context.

• Bug Fixes

  • Refined error handling flow to make task execution more resilient and adaptable to various error scenarios.

• Documentation

  • Minor formatting adjustments made to improve clarity and readability of documentation comments.

[changeset-bot]

🦋 Changeset detected

Latest commit: 63080e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@trigger.dev/core	Patch
@trigger.dev/build	Patch
trigger.dev	Patch
@trigger.dev/sdk	Patch
@internal/redis-worker	Patch
@internal/zod-worker	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch
@internal/testcontainers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces modifications to the HandleErrorArgs type in tasks.ts by adding a new property init: unknown, enhancing the context available for error handling. Additionally, the TaskExecutor class in taskExecutor.ts has been updated to improve error handling and retry logic within the execute method. A new parameter, initOutput, is introduced to the #handleError method, allowing for more detailed error management. Minor formatting adjustments to documentation comments are also included for clarity.

Changes

File Path	Change Summary
packages/core/src/v3/types/tasks.ts	- Updated HandleErrorArgs type to include init: unknown. - Minor formatting adjustments in documentation.
packages/core/src/v3/workers/taskExecutor.ts	- Enhanced #handleError method to include init parameter. - Improved error handling and retry logic in execute method. - Adjusted retry delay calculations for rate limit errors.
.changeset/cold-laws-float.md	- Modified error handling to pass initialization output to local and global handleError functions.

Possibly related PRs

• Prevent abort signals from causing uncaught exceptions #1320: The changes in this PR enhance error handling, which is relevant to the modifications made to the HandleErrorArgs type in the main PR, as both involve improvements in error management.
• fix: cleanup ttl expire run graphile jobs #1373: This PR also deals with error handling in the context of task runs, which relates to the changes made in the main PR regarding the HandleErrorArgs type and its usage in error handling functions.
• Fix several restore and resume bugs #1418: This PR addresses issues related to error handling and resumption processes, which connects to the main PR's focus on enhancing error handling through the updated HandleErrorArgs type.

🐰 In the meadow where bunnies play,
A new init helps keep errors at bay.
With retries and context, we hop with glee,
Task execution is now as smooth as can be!
So let’s celebrate with a joyful cheer,
For clearer docs and logic, we hold dear! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

@trigger.dev/build

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1441

trigger.dev

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1441

@trigger.dev/core

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1441

@trigger.dev/sdk

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1441

@trigger.dev/react-hooks

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1441

commit: 15fdcda