Skip to content

feat: exit if docker buildx can't be found for self-hosted builds #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktrn merged 3 commits into from
Nov 18, 2024
Merged

feat: exit if docker buildx can't be found for self-hosted builds #1475

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa81ea5
feat: exit if docker buildx can't be found for self-hosted builds
ghostdevv Nov 17, 2024
778e2f7
chore: tweak debug log message
ghostdevv Nov 17, 2024
87acfe1
chore: improve error message based on rabbit's suggestion
ghostdevv Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: improve error message based on rabbit's suggestion
  • Loading branch information
@ghostdevv
ghostdevv committed Nov 17, 2024
commit 87acfe1bd0820857b47aed757fc44d70276524d0
4 changes: 3 additions & 1 deletion packages/cli-v3/src/commands/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,9 @@ async function _deployCommand(dir: string, options: DeployCommandOptions) {

if (result.exitCode !== 0) {
logger.debug(`"docker buildx version" failed (${result.exitCode}):`, result);
throw new Error("Failed to find docker buildx, please install it.");
throw new Error(
"Failed to find docker buildx. Please install it: https://github.com/docker/buildx#installing."
);
}
}

Expand Down