Skip to content

RunEngine 2.0 batch trigger support #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-aitken merged 19 commits into from
Jan 2, 2025
Merged

RunEngine 2.0 batch trigger support #1581

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5526dab
Make it clear when BatchTriggerV2Service is used
matt-aitken Dec 17, 2024
a469365
Copy of BatchTriggerV2Service
matt-aitken Dec 17, 2024
64c4a99
WIP batch triggering
matt-aitken Dec 19, 2024
c1306eb
Merge remote-tracking branch 'origin/run-engine-2' into run-engine-ba…
matt-aitken Dec 19, 2024
6259b3d
Allow blocking a run with multiple waitpoints at once. Made it atomic
matt-aitken Dec 29, 2024
adbe83e
Removed unused param
matt-aitken Dec 29, 2024
fb08da1
New batch service
matt-aitken Dec 29, 2024
6aad704
Merge remote-tracking branch 'origin/run-engine-2' into run-engine-ba…
matt-aitken Dec 29, 2024
33b7607
Pass through the parentRunId and resumeParentOnCompletion
matt-aitken Dec 29, 2024
44d954a
Use the new batch service, and correct trigger task version
matt-aitken Dec 29, 2024
31a354a
Force V1 engine if using BatchTriggerV2Service, we’ve already done th…
matt-aitken Dec 30, 2024
45ada5c
Removed the $transaction and early exit if nothing changed
matt-aitken Dec 31, 2024
f0c250f
Merge remote-tracking branch 'origin/run-engine-2' into run-engine-ba…
matt-aitken Dec 31, 2024
98fad73
Adedd a simple batch task to the hello world reference catalog
matt-aitken Dec 31, 2024
8b33031
Fix for batch waits not working
matt-aitken Jan 2, 2025
c308ad2
Added parentRunId in a couple more places
matt-aitken Jan 2, 2025
f0c9fa4
Removed waitForBatch log
matt-aitken Jan 2, 2025
7de5540
Added another parentRunId
matt-aitken Jan 2, 2025
7096239
Expanded the example to include all the different triggers
matt-aitken Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unused param
  • Loading branch information
@matt-aitken
matt-aitken committed Dec 29, 2024
commit adbe83e031a05ee8d5cfcc3593f41ff7e42cbe42
1 change: 0 additions & 1 deletion apps/webapp/app/v3/services/triggerTaskV2.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ export class TriggerTaskServiceV2 extends WithRunEngine {
waitpointId: existingRun.associatedWaitpoint.id,
environmentId: environment.id,
projectId: environment.projectId,
checkWaitpointIsPending: true,
tx: this._prisma,
});
}
Expand Down