Skip to content

Don't create an attempt if the run is final, batchTriggerAndWait bad continue fix #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-aitken merged 6 commits into from
Feb 12, 2025
Merged

Don't create an attempt if the run is final, batchTriggerAndWait bad continue fix #1698

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c19ae5
WIP fix for ResumeAttemptService selecting the wrong attempt (which h…
matt-aitken Feb 11, 2025
b7b3bb0
Don’t create an attempt if the run is already in a final status
matt-aitken Feb 12, 2025
ecf8317
Don’t get all the columns for the query. Improved the logging.
matt-aitken Feb 12, 2025
b215b4d
Merge remote-tracking branch 'origin/main' into fix-stuck-batches-no-…
matt-aitken Feb 12, 2025
eacc3b1
Added a log to the batch example
matt-aitken Feb 12, 2025
3b2b2be
Filter out the undefined values
matt-aitken Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Filter out the undefined values
  • Loading branch information
@matt-aitken
matt-aitken committed Feb 12, 2025
commit 3b2b2bef82a6562e77297a14b3e2cd4ad76ddd47
13 changes: 8 additions & 5 deletions apps/webapp/app/v3/services/resumeAttempt.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,14 @@ export class ResumeAttemptService extends BaseService {

//find the best attempt for each batch item
//it should be the most recent one in a final state
const finalAttempts = dependentBatchItems.map((item) => {
return item.taskRun.attempts
.filter((a) => FINAL_ATTEMPT_STATUSES.includes(a.status))
.sort((a, b) => b.number - a.number)[0];
});
const finalAttempts = dependentBatchItems
.map((item) => {
return item.taskRun.attempts
.filter((a) => FINAL_ATTEMPT_STATUSES.includes(a.status))
.sort((a, b) => b.number - a.number)
.at(0);
})
.filter(Boolean);

completedAttemptIds = finalAttempts.map((a) => a.id);

Expand Down