Skip to content

Misc v4 checkpoint fixes #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktrn merged 25 commits into from
Apr 1, 2025
Merged

Misc v4 checkpoint fixes #1859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
356a90b
logs for optional services
nicktrn Mar 26, 2025
a3a57d9
print env vars on startup in debug mode
nicktrn Mar 26, 2025
d2dd535
routes need to explicitly ask to keep connection alive
nicktrn Mar 27, 2025
af8adf5
Merge remote-tracking branch 'origin/main' into fix/v4-misc
nicktrn Mar 27, 2025
29ce91a
log indicators for now
nicktrn Mar 27, 2025
47f3c33
make workload api listen host configurable
nicktrn Mar 27, 2025
30077c6
expose supervisor metrics and make more configurable
nicktrn Mar 27, 2025
d48aa89
Merge branch 'fix/checkpoints' into fix/v4-misc
nicktrn Mar 27, 2025
a7efef1
configurable pull secrets, no defaults
nicktrn Mar 27, 2025
208711f
remove restore route
nicktrn Mar 31, 2025
3ca58dc
run controller to handle queued executing
nicktrn Mar 31, 2025
756973f
fix v3 deploys in v4 project
nicktrn Mar 31, 2025
ea07b62
update admin worker route
nicktrn Mar 31, 2025
356d810
only start pod cleaner et al in k8s mode
nicktrn Mar 31, 2025
9d6b2ce
set new worker group as default if none yet
nicktrn Mar 31, 2025
21da4e8
Merge remote-tracking branch 'origin/main' into fix/v4-misc
nicktrn Mar 31, 2025
bf36a53
make image ref optional
nicktrn Mar 31, 2025
b74d15d
checkpoint image ref is optional for output as well
nicktrn Mar 31, 2025
3218787
export feature flag const
nicktrn Mar 31, 2025
b8f9dc1
one last image ref type fix
nicktrn Mar 31, 2025
1b35d6b
Merge remote-tracking branch 'origin/main' into fix/v4-checkpoints
nicktrn Mar 31, 2025
0309078
make runner intervals configurable
nicktrn Apr 1, 2025
75c796a
ability to set arbitrary env vars on new runners
nicktrn Apr 1, 2025
9bcc67d
set default runtime back to node 21
nicktrn Apr 1, 2025
405f5e9
move all runner env vars to the same section
nicktrn Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove restore route
  • Loading branch information
@nicktrn
nicktrn committed Mar 31, 2025
commit 208711f9bef93a099ed1e4eb22acdb7d53af1e28
51 changes: 0 additions & 51 deletions ...tes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.restore.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...tes/engine.v1.worker-actions.runs.$runFriendlyId.snapshots.$snapshotFriendlyId.suspend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export const action = createActionWorkerApiRoute(
logger.debug("Suspending run", { runFriendlyId, snapshotFriendlyId, body });

if (!body.success) {
// TODO: we could create a debug span here
logger.error("Failed to suspend run", {
runFriendlyId,
snapshotFriendlyId,
Expand Down