Skip to content

Fix dequeue snapshot batch ids #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktrn merged 3 commits into from
Apr 7, 2025
Merged

Fix dequeue snapshot batch ids #1893

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e80ba3
Pass the batchId through from previous snapshots when dequeuing
matt-aitken Apr 7, 2025
2e575a7
Merge remote-tracking branch 'origin/main' into fix-dequeue-snapshot-…
matt-aitken Apr 7, 2025
a05a9fe
Fix and test for resuming batch after checkpoint
matt-aitken Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Pass the batchId through from previous snapshots when dequeuing
  • Loading branch information
@matt-aitken
matt-aitken committed Apr 7, 2025
commit 5e80ba39dcd4ef926496d84162a213400ffda14c
1 change: 1 addition & 0 deletions internal-packages/run-engine/src/engine/systems/dequeueSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ export class DequeueSystem {
projectId: snapshot.projectId,
organizationId: snapshot.organizationId,
checkpointId: snapshot.checkpointId ?? undefined,
batchId: snapshot.batchId ?? undefined,
completedWaitpoints: snapshot.completedWaitpoints,
workerId,
runnerId,
Expand Down
2 changes: 2 additions & 0 deletions internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ export class RunAttemptSystem {
environmentType: latestSnapshot.environmentType,
projectId: latestSnapshot.projectId,
organizationId: latestSnapshot.organizationId,
batchId: latestSnapshot.batchId ?? undefined,
completedWaitpoints: latestSnapshot.completedWaitpoints,
workerId,
runnerId,
});
Expand Down