Skip to content

Don't show queue time in the run timeline by default #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktrn merged 7 commits into from
Apr 10, 2025
Merged

Don't show queue time in the run timeline by default #1909

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
30c625f
WIP on hiding the queued time
matt-aitken Apr 10, 2025
6e6eddb
Fix for position/sizes of spans
matt-aitken Apr 10, 2025
dbaf622
Fix for duration squashing
matt-aitken Apr 10, 2025
21ff0a2
Tweaked some styles on the timeline
matt-aitken Apr 10, 2025
1df05b0
Fix for retry spans appearing in the wrong place
matt-aitken Apr 10, 2025
a47600d
Added “Q” shortcut key
matt-aitken Apr 10, 2025
f309c6f
Fix for in progress span durations
matt-aitken Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added “Q” shortcut key
  • Loading branch information
@matt-aitken
matt-aitken committed Apr 10, 2025
commit a47600d3665949e97975153d456d3a5a3a1362d0
2 changes: 2 additions & 0 deletions ..._app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@ function TasksTreeView({
label="Queue time"
checked={showQueueTime}
onCheckedChange={(e) => setShowQueueTime(e.valueOf())}
shortcut={{ key: "Q" }}
/>
<Switch
variant="small"
Expand Down Expand Up @@ -1357,6 +1358,7 @@ function KeyboardShortcuts({
title="Collapse all"
/>
<NumberShortcuts toggleLevel={(number) => toggleExpandLevel(number)} />
<ShortcutWithAction shortcut={{ key: "Q" }} title="Queue time" action={() => {}} />
</>
);
}
Expand Down