Skip to content

Set env vars to be "secret" #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-aitken merged 30 commits into from
Apr 17, 2025
Merged

Set env vars to be "secret" #1923

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4e6c4ea
WIP on secret env vars
matt-aitken Apr 11, 2025
0e8b5d3
Editing individual env var values is working
matt-aitken Apr 12, 2025
7d73552
Sort the env vars by the key
matt-aitken Apr 12, 2025
d930104
Deleting values
matt-aitken Apr 12, 2025
ab60348
Allowing setting secret env vars
matt-aitken Apr 14, 2025
ac16ccc
Added medium switch style
matt-aitken Apr 14, 2025
b224d02
Many style changes to the env var form
matt-aitken Apr 14, 2025
7c57aa6
“Copy text” -> “Copy”
matt-aitken Apr 14, 2025
c7a87da
Draw a divider between hidden buttons
matt-aitken Apr 14, 2025
c1b9426
Env var tweaks
matt-aitken Apr 14, 2025
10e714a
Don’t show Dev:you anymore
matt-aitken Apr 14, 2025
707294e
Grouping the same env var keys together
matt-aitken Apr 16, 2025
2d64f09
Styles improved
matt-aitken Apr 16, 2025
a6223fd
Improved styling of edit panel
matt-aitken Apr 16, 2025
f9adbc2
Fix bun detection, dev flushing, and init command (#1914)
nicktrn Apr 11, 2025
e359aae
Release 4.0.0-v4-beta.1 (#1916)
github-actions[bot] Apr 11, 2025
eded802
Both run engines will only lock to versions they can handle (#1922)
nicktrn Apr 13, 2025
2af4178
Add links to and from deployments (#1921)
nicktrn Apr 14, 2025
ff602fc
Fix current worker deployment getter (#1924)
nicktrn Apr 14, 2025
e1f338d
Add a docs page for the human-in-the-loop example project (#1919)
myftija Apr 14, 2025
02a8713
Managed run controller revamp (#1927)
nicktrn Apr 15, 2025
4efdf64
Release 4.0.0-v4-beta.2 (#1928)
github-actions[bot] Apr 15, 2025
8b7d090
Remove batch ID carryover for non-batch waits (#1930)
nicktrn Apr 16, 2025
f6f628e
Delete project (#1913)
matt-aitken Apr 16, 2025
78f8411
Improve usage flushing (#1931)
nicktrn Apr 16, 2025
6ba85b5
For secret env vars, don’t return the value
matt-aitken Apr 16, 2025
6d508ca
Added a new env var repository function for getting secrets with reda…
matt-aitken Apr 16, 2025
512dbb6
Test task for env vars
matt-aitken Apr 17, 2025
2a45200
Merge remote-tracking branch 'origin/main' into secret-env-vars
matt-aitken Apr 17, 2025
8ace735
Delete heartbeat file, merge mess up
matt-aitken Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Env var tweaks
  • Loading branch information
@matt-aitken
matt-aitken committed Apr 14, 2025
commit c1b942653f66335dfa0b6806ee57d0f35ba17b14
18 changes: 7 additions & 11 deletions ...gs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ import {
type EnvironmentVariableWithSetValues,
EnvironmentVariablesPresenter,
} from "~/presenters/v3/EnvironmentVariablesPresenter.server";
import { logger } from "~/services/logger.server";
import { requireUserId } from "~/services/session.server";
import { cn } from "~/utils/cn";
import {
Expand All @@ -66,7 +65,6 @@ import {
} from "~/utils/pathBuilder";
import { EnvironmentVariablesRepository } from "~/v3/environmentVariables/environmentVariablesRepository.server";
import {
DeleteEnvironmentVariable,
DeleteEnvironmentVariableValue,
EditEnvironmentVariableValue,
} from "~/v3/environmentVariables/repository";
Expand Down Expand Up @@ -238,9 +236,9 @@ export default function Page() {
<Table containerClassName={cn(environmentVariables.length === 0 && "border-t-0")}>
<TableHeader>
<TableRow>
<TableHeaderCell>Key</TableHeaderCell>
<TableHeaderCell>Value</TableHeaderCell>
<TableHeaderCell>Environment</TableHeaderCell>
<TableHeaderCell className="w-[25%]">Key</TableHeaderCell>
<TableHeaderCell className="w-[55%]">Value</TableHeaderCell>
<TableHeaderCell className="w-[20%]">Environment</TableHeaderCell>
<TableHeaderCell hiddenLabel className="pl-24">
Actions
</TableHeaderCell>
Expand All @@ -258,20 +256,18 @@ export default function Page() {
<SimpleTooltip
button={
<div className="flex items-center gap-x-1.5">
<LockClosedIcon className="size-4 text-text-dimmed" />
<LockClosedIcon className="size-3 text-text-dimmed" />
<span className="text-sm text-text-dimmed">Secret</span>
</div>
}
content="This variable is secret and cannot be revealed."
/>
) : (
<ClipboardField
className="-ml-2"
secure={!revealAll}
value={variable.value}
variant={"tertiary/small"}
iconButton
fullWidth={false}
variant={"secondary/small"}
fullWidth={true}
/>
)}
</TableCell>
Expand Down Expand Up @@ -445,7 +441,7 @@ function DeleteEnvironmentVariableButton({
textAlignLeft
LeadingIcon={TrashIcon}
leadingIconClassName="text-rose-500 group-hover/button:text-text-bright transition-colors"
className="transition-colors group-hover/button:bg-error"
className="ml-0.5 transition-colors group-hover/button:bg-error"
>
{isLoading ? "Deleting" : "Delete"}
</Button>
Expand Down