fix(search): cancel pending rAF on stop and populate cache synchronously on start#7
Merged
Merged
Conversation
…efresh Co-authored-by: trivikr <16024985+trivikr@users.noreply.github.com> Agent-Logs-Url: https://github.com/trivikr/npmx.dev/sessions/4ab0d95d-1968-46f2-9081-d92a0d5cabea
Copilot
AI
changed the title
[WIP] Update search keyboard navigation to use cached focus targets
fix(search): cancel pending rAF on stop and populate cache synchronously on start
Mar 25, 2026
trivikr
approved these changes
Mar 25, 2026
trivikr
added a commit
that referenced
this pull request
Apr 12, 2026
…sly on start (#7) Co-authored-by: trivikr <16024985+trivikr@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
trivikr
added a commit
that referenced
this pull request
Apr 17, 2026
…sly on start (#7) Co-authored-by: trivikr <16024985+trivikr@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two correctness gaps in the keyboard navigation focus cache lifecycle introduced by the MutationObserver/rAF caching layer.
Changes
stopObservingFocusableElements()— cancel any in-flightrequestAnimationFramebefore clearing the cache; previously a pending rAF could fire after stop and briefly repopulatefocusableElementsstartObservingFocusableElements()— callrefreshFocusableElements()synchronously after attaching the observer so the cache is ready before the first keypress; the rAF-scheduled refresh is kept for coalescing subsequent mutation callbacks📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.