Fix manualEdits placement inside positioned groups#2313
Open
garrettparker245-code wants to merge 6 commits into
Open
Fix manualEdits placement inside positioned groups#2313garrettparker245-code wants to merge 6 commits into
garrettparker245-code wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2281.
Summary
manualEdits.pcb_placementsinside positioned groups in board/subcircuit coordinates instead of applying the parent group transform again.Tests
bun test tests/pcb-packing/manual-edits-positioned-group-anchor-pcb.test.tsx tests/components/normal-components/manual-edits-positioned-group-anchor-schematic.test.tsxbunx tsc --noEmitbunx biome format lib/components/base-components/PrimitiveComponent/PrimitiveComponent.ts lib/components/primitive-components/Group/Group_doInitialPcbLayoutPack/Group_doInitialPcbLayoutPack.ts lib/components/primitive-components/Group/Group_doInitialPcbLayoutPack/applyPackOutput.ts tests/pcb-packing/manual-edits-positioned-group-anchor-pcb.test.tsx tests/components/normal-components/manual-edits-positioned-group-anchor-schematic.test.tsx --writeNote
No bounty is currently attached to this issue, but if this fix is useful and you are open to tipping via Algora or another public route, that would be appreciated.