add netLabelWidth to directConnections#2317
Merged
Merged
Conversation
Contributor
Sang-it
commented
May 21, 2026
Sang-it
commented
- add netLabelWidth for direct connections
- update schematic trace solver
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
reviewed
May 21, 2026
| (portA.center.y - portB.center.y) ** 2, | ||
| ) | ||
| : 0 | ||
| const maxMspDist = group._parsedProps.schMaxTraceDistance ?? 2.4 |
Contributor
Author
There was a problem hiding this comment.
added a const for it
imrishabh18
approved these changes
May 21, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.