Conversation
d5fa90a to
f5d1cb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the internal ffi module,
which had been used to wrap the low-level C
types.
It is no longer clear that we have a robust
pattern warranting a trait.
So we are removing the internal trait until
such a pattern becomes clear.
The issues are:
The table collection is the main example here:
we need to malloc it so that a tree sequence
can steal its pointer.
structures.
This requirement leads to rust code that looks
sketchy at first glance.
This PR refactors that code to leave things
in either a NonNull or a MaybeUninit as long
as possible.