Return &str from provenance table getters#403
Merged
Conversation
Member
molpopgen
commented
Nov 9, 2022
molpopgen
commented
- refactor: provenance getters now return Option<&str>
- reduce internal code duplication
BREAKING CHANGE: return value changed. Existing code only breaks if it depended on the return value being a String.
molpopgen
added a commit
that referenced
this pull request
Nov 9, 2022
* reduce internal code duplication BREAKING CHANGE: return value changed. Existing code only breaks if it depended on the return value being a String.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.