Low level pair coalescence rates#2985
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2985 +/- ##
==========================================
+ Coverage 89.65% 89.71% +0.05%
==========================================
Files 29 29
Lines 31116 31298 +182
Branches 6031 6067 +36
==========================================
+ Hits 27898 28078 +180
- Misses 1836 1837 +1
- Partials 1382 1383 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0b0e591 to
f063103
Compare
Typo in docstring
f063103 to
2bc7118
Compare
|
Hey @jeromekelleher this is ready to be merged after a review. Thanks! One question is what the output fill value should be for time windows that do not contain any nodes. I'm filling these with NaN at the moment, but zero also makes sense in this particular context. Maybe it should match what will be done for other time-windowed statistics (@petrelharp and @tforest have you decided on this?) |
| j = 0; | ||
| coalesced = 0.0; | ||
| timepoint = -INFINITY; | ||
| /* TODO: may be more efficient to use a binary search */ |
There was a problem hiding this comment.
Just to note we have tsk_search_sorted if you want to try it out
Low level pair coalescence rates within time windows, followup to #2976