New Appliance: Mumble

Created a Mumble Appliance need additional testers and code review/comment.

https://github.com/MPTMG/Mumble

[a3s7p]

Thanks for the contribution!

I'll take a look and get back to you.

[DocCyblade]

I'll take a look as well. Would you mind if I open issues on your repo? I find that way you have a more precise way of listing the things to do and a nice clear place for dialog! I do this my self on my contributions. I am currently working on Mayan EDMS and last year I helped out with Odoo, feel free to take a look at the code base for use patterns as well.

Feel free to open issues on the repo. I will do whatever is necessary to ensure that it meets the TKL standards and complies with any best practices you guys may have for this sort of thing. Honest feedback yields the best end result.

[DocCyblade]

@mptmg - I had a quick look at the code, I opened up a few issues. Feel free to start discussion in the issues.

Latest commit includes suggestions proposed by DocCyblade (thanks again).

[DocCyblade]

@mptmg - I'll have a look when I get home this evening.

[DocCyblade]

@mptmg - I apologize for the delayed response have been sick as of late :-(

I did a quick build and it seems to build. I am doing a quick review of the build scripts now.

[JedMeister]

@mptmg - as the others have said, thanks again for your contribution! 😄

Thanks @qrntz for jumping straight in.

And extra thanks to (one of our premier community champions) @DocCyblade on taking the lead on helping to create an appliance that confirms to our standards.

As an aside (and I'm sure I've mentioned previously), I think we probably should provide a simple clear checklist of requirements for new apps. Perhaps it should be a separate doc called new-checklist.rst (or similar) and added to https://github.com/turnkeylinux-apps/tkldev/tree/master/docs/development/ ?

Just let me know what additional things need to be done for you guys to include this. Still working on one last thing from DocCyblade in reference to auto opening ports as additional servers are created. Additional web interface for Mumble (phpMumbleAdmin) will be added soon.

[DocCyblade]

@JedMeister - welcome back! I agree with the check list. I can open a new issue and we can discuss this further there if you would like.

[JedMeister]

@mptmg - I have had a really quick glance and it looks like a great app. I will have a closer look and follow @DocCyblade's lead and open issues on your repo for anything I discover.

@DocCyblade - once again, champion effort! 😄

Committed code tonight. Changes include additional web interface phpMumbleAdmin, script and daemon for opening firewall ports automatically (checks every 5 minutes), sed statement changes for resiliency to special characters, inithooks for phpMumbleAdmin.

[a3s7p]

Sorry this took me a while! Please review/comment PR above.

Did anyone else witness 30rootpass not being executed properly (root password remains «turnkey»)? If not, must be something broken in my system.