fix: don't use id as filename, but id + fileExtension#95
Merged
Conversation
Author
|
Probably fixes #77 |
Contributor
|
Thanks for fixing this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes that on the TUS server the file is not created with its id, but with the id + file extensions. This has the advantage, that the TUS server will return the file with the correct extension, which some clients may rely on.
Also, our TUS server implementation relies on the file extension as we need to process some files based on their file type.
I am not sure whether this is something that we wouldn't do in the "TUS ecosystem", however, I find that the android/java library does this also.
(As I am building a react native bridge (thus one lib for android & iOS) its great to have behaviour the same across platforms).