fix: xo 2.0 compatibility#400
Merged
Merged
Conversation
Bumps [xo](https://github.com/xojs/xo) from 1.2.3 to 2.0.2. - [Release notes](https://github.com/xojs/xo/releases) - [Commits](xojs/xo@v1.2.3...v2.0.2) --- updated-dependencies: - dependency-name: xo dependency-version: 2.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
xo 2.0 enabled @typescript-eslint/no-useless-constructor and require-unicode-regexp. The constructor was a no-op once class field initializers were introduced, so it can simply be removed. The Unicode regex rule is a false positive here: Cache-Control headers are strictly ASCII per RFC 9110/9111, so the v flag adds no value and its stricter escaping rules cause friction. Disable it project-wide. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #400 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 114 113 -1
Branches 17 17
=========================================
- Hits 114 113 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CacheControlconstructor — xo 2.0 enables@typescript-eslint/no-useless-constructor, and class field initializers already cover what it was doingrequire-unicode-regexpglobally inxo.config.ts— Cache-Control headers are strictly ASCII per RFC 9110/9111, so thevflag adds no value and its stricter escaping rules cause frictionCloses #399
Test plan
pnpm xo— cleanpnpm tsc --noEmit— cleanpnpm test— 57/57 pass, 100% coverage🤖 Generated with Claude Code