fix(engine): add missing điu pattern to _consonantD table#323
Closed
mantrandev wants to merge 1 commit into
Closed
fix(engine): add missing điu pattern to _consonantD table#323mantrandev wants to merge 1 commit into
mantrandev wants to merge 1 commit into
Conversation
7b5b79d to
ba6212d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{KEY_D, KEY_I, KEY_U}was missing from_consonantDinVietnamese.cppdiu91produced literaldiu91instead ofđíud9iu1worked because the buffer held just[d]when9arrived, matching the existing{KEY_D}entryRoot cause
When
9(the VNI đ-key,IS_KEY_D) is pressed afterdiu, the engine scans_consonantDfor a matching syllable pattern.{KEY_D, KEY_I, KEY_U}did not exist, so the engine fell through and inserted9as a literal character. After that,1(sắc) found a non-vowel-ending buffer and also fell through as a literal.Test plan
diu91in VNI mode → should produceđíud9iu1in VNI mode → should still produceđíudiu+ other tone marks (diu92,diu93, etc.) → verify tones apply correctly