Refactor chart release action#143
Merged
Michael Vittrup Larsen (michaelvl) merged 3 commits intomainfrom Apr 24, 2023
Merged
Conversation
Michael Vittrup Larsen (michaelvl)
requested a review
from Martin Villumsen (mvillumsen)
as a code owner
Michael Vittrup Larsen (michaelvl)
changed the title
Martin Villumsen (mvillumsen)
approved these changes
Apr 24, 2023
Contributor
Martin Villumsen (mvillumsen)
left a comment
Martin Villumsen (mvillumsen)
left a comment
There was a problem hiding this comment.
Awesome 💪
Michael Vittrup Larsen (michaelvl)
deleted the
feature/refactor-chart-release
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the chart release process. This removes the conflicting tagging triggered by
chart-releaser-action`.Charts are now packaged with
helm packageand push to theghcr.ioOCI container registry instead of a branch in the repo. This also means, that actions no longer need to have write access to the repo. Charts are also signed withcosign.This PR does not update user docs - a follow up PR will do that using a chart published to the container registry.