test: update getting started guide and enable external dns filter#169
Merged
Michael Vittrup Larsen (michaelvl) merged 5 commits intomainfrom May 24, 2023
Conversation
Michael Vittrup Larsen (michaelvl)
requested a review
from Martin Villumsen (mvillumsen)
as a code owner
Michael Vittrup Larsen (michaelvl)
changed the title
Michael Vittrup Larsen (michaelvl)
force-pushed
the
test/update-getting-started-external-dns-filter
branch
2 times, most recently
from
972cb0b to
77ad9e9
Compare
Michael Vittrup Larsen (michaelvl)
requested a review
from Sebastian Kalita (kuketro)
as a code owner
…l dns chart. Propagate hostname on contour-istio blueprint gateways
…nge external-dns policy to sync (was upsert)
Michael Vittrup Larsen (michaelvl)
force-pushed
the
test/update-getting-started-external-dns-filter
branch
from
77ad9e9 to
33aac7d
Compare
Sebastian Kalita (kuketro)
approved these changes
May 23, 2023
Michael Vittrup Larsen (michaelvl)
deleted the
test/update-getting-started-external-dns-filter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the external-dns and bifrost versions used in make targets.
The
contour-istioblueprint child gateway template is aligned withaws-crossplane-istio. The reason for this construction of the gateway listener section is to avoid passing thetlssection from parent gateway to child gateway since TLS is termianted at the parent.This also contains test/documentation updates. The getting-started usecase is updated to illustrate integration with external-dns. External-dns is enabled through a label on
Gateways.Checklist